Add sampling.ttl.discard_on_write_failure to sample yml #17064
Merged
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
carsonip
approved these changes
Jun 2, 2025
isaacaflores2
force-pushed
the
feature/discard-write-failure-sample-config
branch
3 times, most recently
from
afcc032 to
a88361a
Compare
isaacaflores2
force-pushed
the
feature/discard-write-failure-sample-config
branch
from
a88361a to
053b1af
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
(cherry picked from commit d0c7565)
isaacaflores2
added a commit
that referenced
this pull request
Jun 3, 2025
(cherry picked from commit d0c7565)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Adding
discard_on_write_failureto sample yaml filesChecklist
For functional changes, consider:
How to test these changes
Related issues
Part of #15330