[8.19] (backport #21274) tf: configurable ec_target for smoke and benchmark#21281
Merged
Conversation
* tf: Configurable ec_target * Revert change * Push ec_target down to ec_deployment * Refactor * Revert standalone ac url * Update region * Smoke test set EC target * Update to use QA regions * Change qa region * Move worker to same region * Use closest region in profiles * tf format * Address review comments * fail fast * Description * Update readme * Remove EC_TARGET (cherry picked from commit 3ecb34d) # Conflicts: # testing/infra/terraform/modules/ec_deployment/outputs.tf
Contributor
Author
|
Cherry-pick of 3ecb34d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
🤖 GitHub commentsJust comment with:
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
carsonip
reviewed
Jun 29, 2026
carsonip
approved these changes
Jun 29, 2026
Contributor
Author
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Author
Merge Queue Status
This pull request spent 4 minutes 23 seconds in the queue, including 3 minutes 42 seconds running CI. Required conditions to merge
|
Contributor
💚 Build Succeeded
cc @carsonip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Align benchmark and smoke Terraform workflows with QA-targeted runs while keeping production defaults explicit and preserving
pronaming used by secret storage.This PR:
ec_targetsupport (qa|pro) to benchmark and smoke Terraform stacks, with validation and a note thatprois the production secret-storage keyecprovider endpoint mapping to use API hosts by target (qa -> public-api.qa.cld.elstc.co,pro -> api.elastic-cloud.com)ec_targetthrough to the sharedec_deploymentmodule and adds module-level target validationadmin_console_urlsmapping inec_deploymentsoadmin_console_urlresolves to QA (admin.qa.cld.elstc.co) or production (admin.found.no) correctlyTF_VAR_ec_targetonly (normalized to lowercase) and append/api/v1at call sitesTF_VAR_ec_target: qa, and smokeTF_VAR_region: gcp-us-central1)ess_regionvalues and definesworker_regionper profile (closest worker region)testing/infra/terraform/modules/ec_deploymentChecklist
For functional changes, consider:
How to test these changes
Manually trigger workflow in GH Actions
Related issues
Fixes #21268
Supersedes #21269
Follow-up to #21222
This is an automatic backport of pull request #21274 done by Mergify.