-
Notifications
You must be signed in to change notification settings - Fork 5k
x-pack/filebeat/input/salesforce: Add optional token_url support for JWT Bearer Flow authentication
#43933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shmsr
wants to merge
7
commits into
elastic:main
Choose a base branch
from
shmsr:jwt-token-endpoint-custom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
x-pack/filebeat/input/salesforce: Add optional token_url support for JWT Bearer Flow authentication
#43933
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
140c740
x-pack/filebeat/input/salesforce: Use new JWT provider to include opt…
shmsr 4fde748
Add CL
shmsr e9c2a3a
Merge branch 'main' into jwt-token-endpoint-custom
shmsr 2711af6
Merge branch 'main' into jwt-token-endpoint-custom
shmsr d7951e6
Update x-pack/filebeat/input/salesforce/config_auth.go
shmsr ed34877
Merge branch 'main' into jwt-token-endpoint-custom
shmsr 9c0da25
Fix example url
shmsr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13304,11 +13304,11 @@ Contents of probable licence file $GOMODCACHE/github.com/elastic/go-seccomp-bpf@ | |
|
|
||
| -------------------------------------------------------------------------------- | ||
| Dependency : github.com/elastic/go-sfdc | ||
| Version: v0.0.0-20241010131323-8e176480d727 | ||
| Version: v0.0.0-20251207194532-c5aadd4a4e06 | ||
| Licence type (autodetected): MIT | ||
| -------------------------------------------------------------------------------- | ||
|
|
||
| Contents of probable licence file $GOMODCACHE/github.com/elastic/[email protected]20241010131323-8e176480d727/LICENSE.txt: | ||
| Contents of probable licence file $GOMODCACHE/github.com/elastic/[email protected]20251207194532-c5aadd4a4e06/LICENSE.txt: | ||
|
|
||
| MIT License | ||
|
|
||
|
|
||
50 changes: 50 additions & 0 deletions
50
changelog/fragments/1765138168-salesforce-jwt-custom-endpoint.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # REQUIRED | ||
| # Kind can be one of: | ||
| # - breaking-change: a change to previously-documented behavior | ||
| # - deprecation: functionality that is being removed in a later release | ||
| # - bug-fix: fixes a problem in a previous version | ||
| # - enhancement: extends functionality but does not break or fix existing behavior | ||
| # - feature: new functionality | ||
| # - known-issue: problems that we are aware of in a given version | ||
| # - security: impacts on the security of a product or a user's deployment. | ||
| # - upgrade: important information for someone upgrading from a prior version | ||
| # - other: does not fit into any of the other categories | ||
| kind: enhancement | ||
|
|
||
| # REQUIRED for all kinds | ||
| # Change summary; a 80ish characters long description of the change. | ||
| summary: Add optional token_url support for JWT Bearer Flow in Salesforce input. | ||
|
|
||
| # REQUIRED for breaking-change, deprecation, known-issue | ||
| # Long description; in case the summary is not enough to describe the change | ||
| # this field accommodate a description without length limits. | ||
| description: | | ||
| The Salesforce input now supports a separate `token_url` configuration for JWT Bearer Flow | ||
| authentication. This allows users with custom Salesforce domains or restrictions on default | ||
| endpoints (login.salesforce.com/test.salesforce.com) to specify a different token endpoint | ||
| URL while keeping the audience URL separate. If token_url is not provided, the existing | ||
| behavior of using the audience URL as the token endpoint is maintained. | ||
|
|
||
| # REQUIRED for breaking-change, deprecation, known-issue | ||
| # impact: | ||
|
|
||
| # REQUIRED for breaking-change, deprecation, known-issue | ||
| # action: | ||
|
|
||
| # REQUIRED for all kinds | ||
| # Affected component; usually one of "elastic-agent", "fleet-server", "filebeat", "metricbeat", "auditbeat", "all", etc. | ||
| component: filebeat | ||
|
|
||
| # AUTOMATED | ||
| # OPTIONAL to manually add other PR URLs | ||
| # PR URL: A link the PR that added the changeset. | ||
| # If not present is automatically filled by the tooling finding the PR where this changelog fragment has been added. | ||
| # NOTE: the tooling supports backports, so it's able to fill the original PR number instead of the backport PR number. | ||
| # Please provide it if you are adding a fragment for a different PR. | ||
| # pr: https://github.com/owner/repo/1234 | ||
|
|
||
| # AUTOMATED | ||
| # OPTIONAL to manually add other issue URLs | ||
| # Issue URL; optional; the GitHub issue related to this changeset (either closes or is part of). | ||
| # If not present is automatically filled by the tooling with the issue linked to the PR number. | ||
| issue: https://github.com/elastic/beats/issues/43963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,6 +118,7 @@ Example config: | |
| client.username: "[email protected]" | ||
| client.key_path: client_key.pem | ||
| url: https://login.salesforce.com | ||
| token_url: "https://[custom-domain].my.salesforce.com" | ||
| user_password_flow: | ||
| enabled: true | ||
| client.id: "my-client-id" | ||
|
|
@@ -168,6 +169,10 @@ Path to the client key file for JWT authentication. | |
|
|
||
| The audience URL for JWT authentication. | ||
|
|
||
| *`var.authentication.jwt_bearer_flow.token_url`*:: | ||
|
|
||
| The Salesforce OAuth token endpoint for JWT authentication. This endpoint is used for JWT Bearer flow and defaults to `var.authentication.jwt_bearer_flow.url` if empty. Only use a custom value if you have a custom domain and don't allow default endpoints such as `https://login.salesforce.com` or `https://test.salesforce.com`. | ||
|
|
||
| *`var.authentication.user_password_flow.enabled`*:: | ||
|
|
||
| Set to true to use user-password authentication. | ||
|
|
@@ -236,6 +241,7 @@ Example config: | |
| client.username: "[email protected]" | ||
| client.key_path: client_key.pem | ||
| url: https://login.salesforce.com | ||
| token_url: "https://[custom-domain].my.salesforce.com" | ||
| user_password_flow: | ||
| enabled: true | ||
| client.id: "my-client-id" | ||
|
|
@@ -286,6 +292,10 @@ Path to the client key file for JWT authentication. | |
|
|
||
| The audience URL for JWT authentication. | ||
|
|
||
| *`var.authentication.jwt_bearer_flow.token_url`*:: | ||
|
|
||
| The Salesforce OAuth token endpoint for JWT authentication. This endpoint is used for JWT Bearer flow and defaults to `var.authentication.jwt_bearer_flow.url` if empty. Only use a custom value if you have a custom domain and don't allow default endpoints such as `https://login.salesforce.com` or `https://test.salesforce.com`. | ||
|
|
||
| *`var.authentication.user_password_flow.enabled`*:: | ||
|
|
||
| Set to true to use user-password authentication. | ||
|
|
@@ -354,6 +364,7 @@ Example config: | |
| client.username: "[email protected]" | ||
| client.key_path: client_key.pem | ||
| url: https://login.salesforce.com | ||
| token_url: "https://[custom-domain].my.salesforce.com" | ||
| user_password_flow: | ||
| enabled: true | ||
| client.id: "my-client-id" | ||
|
|
@@ -400,6 +411,10 @@ Path to the client key file for JWT authentication. | |
|
|
||
| The audience URL for JWT authentication. | ||
|
|
||
| *`var.authentication.jwt_bearer_flow.token_url`*:: | ||
|
|
||
| The Salesforce OAuth token endpoint for JWT authentication. This endpoint is used for JWT Bearer flow and defaults to `var.authentication.jwt_bearer_flow.url` if empty. Only use a custom value if you have a custom domain and don't allow default endpoints such as `https://login.salesforce.com` or `https://test.salesforce.com`. | ||
|
|
||
| *`var.authentication.user_password_flow.enabled`*:: | ||
|
|
||
| Set to true to use user-password authentication. | ||
|
|
@@ -457,6 +472,7 @@ Example config: | |
| client.username: "[email protected]" | ||
| client.key_path: client_key.pem | ||
| url: https://login.salesforce.com | ||
| token_url: "https://[custom-domain].my.salesforce.com" | ||
| user_password_flow: | ||
| enabled: true | ||
| client.id: "my-client-id" | ||
|
|
@@ -504,6 +520,10 @@ Path to the client key file for JWT authentication. | |
|
|
||
| The audience URL for JWT authentication. | ||
|
|
||
| *`var.authentication.jwt_bearer_flow.token_url`*:: | ||
|
|
||
| The Salesforce OAuth token endpoint for JWT authentication. This endpoint is used for JWT Bearer flow and defaults to `var.authentication.jwt_bearer_flow.url` if empty. Only use a custom value if you have a custom domain and don't allow default endpoints such as `https://login.salesforce.com` or `https://test.salesforce.com`. | ||
|
|
||
| *`var.authentication.user_password_flow.enabled`*:: | ||
|
|
||
| Set to true to use user-password authentication. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.