[8.19](backport #44442) metricbeat: ensure event.duration field is not discarded on Windows #44454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…44442) * metricbeat: ensure event.duration field is not discarded on Windows Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end may be below this resolution, resulting in a zero duration. A zero event duration is interpreted as absence of value and discarded when setting event fields. This commit ensures a minimum duration is always set. * linter fixes * use rand.N * add changelog (cherry picked from commit 7839c6b)
mergify
bot
requested review from
rdner and
mauri870
and removed request for
a team
botelastic
bot
added
the
needs_team
github-actions
bot
added
bug
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
pierrehilbert
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end timestamps may be less than this resolution, resulting in a diff of zero.
A zero event duration is interpreted as absence of value and discarded when setting event fields.
This commit ensures a minimum duration is set to preserve event.duration in the ingested event.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues
This is an automatic backport of pull request metricbeat: ensure event.duration field is not discarded on Windows #44442 done by Mergify.