Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 30, 2025

Proposed commit message

Similar to elastic/elastic-agent#10202.

Adds a retry mechanism when creating a named pipe listener on Windows.
Instead of failing immediately if listener creation fails, it now retries for up to 50 times with a short delay between attempts.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • x ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

This is an automatic backport of pull request #46846 done by [Mergify](https://mergify.com).

* fix: add retry for listener creation in libbeat

* rename

* context

* remove deprecated

* cleanup

* cleanup

* retry at API level instead of listener

(cherry picked from commit 32b5e5a)

# Conflicts:
#	x-pack/libbeat/cmd/instance/receiver.go
@mergify mergify bot requested a review from a team as a code owner September 30, 2025 17:25
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Sep 30, 2025
@mergify mergify bot requested review from mauri870 and rdner and removed request for a team September 30, 2025 17:25
@mergify
Copy link
Contributor Author

mergify bot commented Sep 30, 2025

Cherry-pick of 32b5e5a has failed:

On branch mergify/bp/8.19/pr-46846
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 32b5e5a5e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x-pack/filebeat/fbreceiver/factory.go
	modified:   x-pack/metricbeat/mbreceiver/factory.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/libbeat/cmd/instance/receiver.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 30, 2025
@github-actions github-actions bot added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 30, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 30, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Oct 6, 2025

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏

@pierrehilbert pierrehilbert merged commit aa9ef37 into 8.19 Oct 7, 2025
109 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.19/pr-46846 branch October 7, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants