-
Notifications
You must be signed in to change notification settings - Fork 5k
[Azure] Add client secret (Oauth2) support for eventhub filebeat input #47256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kaiyan-sheng
wants to merge
22
commits into
main
Choose a base branch
from
oauth2_azure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a0811eb
add oauth2 support
kaiyan-sheng c6ff76b
fix parsing connection string when using oauth2
kaiyan-sheng 25a4dd1
support oauth2 with storage account
kaiyan-sheng ba53a00
add tests
kaiyan-sheng 8f9f12b
update doc
kaiyan-sheng 147f4f1
update doc
kaiyan-sheng 1c80794
add auth_type
kaiyan-sheng 17d85a3
fix unit tests
kaiyan-sheng 2d1f3d9
add more tests for the config options
kaiyan-sheng 732f984
update changelog
kaiyan-sheng bdba159
fix lint
kaiyan-sheng 44c0d17
move checking authType into the client funcs
kaiyan-sheng e909982
fix v2_migration to check for both connection string and eventhub nam…
kaiyan-sheng 0af0f55
change migrate_checkpoint to true
kaiyan-sheng fdc43ad
move to GetFullyQualifiedEventHubNamespace function
kaiyan-sheng a45da38
Merge remote-tracking branch 'upstream/main' into oauth2_azure
kaiyan-sheng 820861a
refactor authenticator
kaiyan-sheng 296a37f
remove unused code
kaiyan-sheng 9deb528
use azureInputConfig instead of authConfig
kaiyan-sheng 55ce7e8
support diff domains for the storage account url
kaiyan-sheng 3ee1971
remove config.Validate()
kaiyan-sheng 5602b8c
add extra line back
kaiyan-sheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
45 changes: 45 additions & 0 deletions
45
changelog/fragments/1761678237-feat-add-client-secret-auth-for-azure-eventhub.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # REQUIRED | ||
| # Kind can be one of: | ||
| # - breaking-change: a change to previously-documented behavior | ||
| # - deprecation: functionality that is being removed in a later release | ||
| # - bug-fix: fixes a problem in a previous version | ||
| # - enhancement: extends functionality but does not break or fix existing behavior | ||
| # - feature: new functionality | ||
| # - known-issue: problems that we are aware of in a given version | ||
| # - security: impacts on the security of a product or a user’s deployment. | ||
| # - upgrade: important information for someone upgrading from a prior version | ||
| # - other: does not fit into any of the other categories | ||
| kind: feature | ||
|
|
||
| # REQUIRED for all kinds | ||
| # Change summary; a 80ish characters long description of the change. | ||
| summary: Add client secret authentication method for Azure Event Hub and storage in Filebeat. | ||
|
|
||
| # REQUIRED for breaking-change, deprecation, known-issue | ||
| # Long description; in case the summary is not enough to describe the change | ||
| # this field accommodate a description without length limits. | ||
| # description: | ||
|
|
||
| # REQUIRED for breaking-change, deprecation, known-issue | ||
| # impact: | ||
|
|
||
| # REQUIRED for breaking-change, deprecation, known-issue | ||
| # action: | ||
|
|
||
| # REQUIRED for all kinds | ||
| # Affected component; usually one of "elastic-agent", "fleet-server", "filebeat", "metricbeat", "auditbeat", "all", etc. | ||
| component: "filebeat" | ||
|
|
||
| # AUTOMATED | ||
| # OPTIONAL to manually add other PR URLs | ||
| # PR URL: A link the PR that added the changeset. | ||
| # If not present is automatically filled by the tooling finding the PR where this changelog fragment has been added. | ||
| # NOTE: the tooling supports backports, so it's able to fill the original PR number instead of the backport PR number. | ||
| # Please provide it if you are adding a fragment for a different PR. | ||
| # pr: https://github.com/owner/repo/1234 | ||
|
|
||
| # AUTOMATED | ||
| # OPTIONAL to manually add other issue URLs | ||
| # Issue URL; optional; the GitHub issue related to this changeset (either closes or is part of). | ||
| # If not present is automatically filled by the tooling with the issue linked to the PR number. | ||
| # issue: https://github.com/owner/repo/1234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -282,7 +282,7 @@ Using the following configuration: | |
| storage_account_key: "<redacted>" | ||
| storage_account_connection_string: "<redacted>" | ||
| processor_version: "v1" | ||
| migrate_checkpoint: yes | ||
| migrate_checkpoint: true | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know why is no longer working with |
||
| start_position: "earliest" | ||
| ``` | ||
|
|
||
|
|
@@ -377,7 +377,7 @@ Stop Filebeat and update the config with the following changes: | |
| storage_account_key: "<redacted>" | ||
| storage_account_connection_string: "<redacted>" # NOTE: make sure this is set | ||
| processor_version: "v2" # CHANGE: v1 > v2 | ||
| migrate_checkpoint: yes | ||
| migrate_checkpoint: true | ||
| start_position: "earliest" | ||
| ``` | ||
|
|
||
|
|
@@ -438,7 +438,7 @@ Using the following configuration: | |
| storage_account_key: "<redacted>" | ||
| storage_account_connection_string: "<redacted>" | ||
| processor_version: "v2" | ||
| migrate_checkpoint: yes | ||
| migrate_checkpoint: true | ||
| start_position: "earliest" | ||
| ``` | ||
|
|
||
|
|
@@ -564,7 +564,7 @@ Using the following configuration for all inputs: | |
| storage_account_key: "<redacted>" | ||
| storage_account_connection_string: "<redacted>" | ||
| processor_version: "v2" | ||
| migrate_checkpoint: yes | ||
| migrate_checkpoint: true | ||
| start_position: "earliest" | ||
| ``` | ||
|
|
||
|
|
@@ -783,7 +783,7 @@ Using the following configuration: | |
| storage_account_key: "<redacted>" | ||
| storage_account_connection_string: "<redacted>" | ||
| processor_version: "v2" | ||
| migrate_checkpoint: yes | ||
| migrate_checkpoint: true | ||
| start_position: "earliest" | ||
| ``` | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.