Skip to content

Conversation

@orestisfl
Copy link
Contributor

Proposed commit message

Switches the openai module to ReportingMetricSetV2WithContext to get rid of a context.TODO().

Taking a look in persistcache.go, I see that we probably don't really need any of the two sync.RWMutexes since the only write-able state is in a sync.Map.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

How to test this PR locally

Related issues

Switches the openai module to ReportingMetricSetV2WithContext to get rid
of a context.TODO().
@orestisfl orestisfl self-assigned this Oct 29, 2025
@orestisfl orestisfl requested a review from a team as a code owner October 29, 2025 14:19
@orestisfl orestisfl added enhancement cleanup backport-skip Skip notification from the automated backport with mergify Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team skip-changelog labels Oct 29, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 29, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify cleanup enhancement skip-changelog Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant