- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5k
 
Include whether Beat is running from a FIPS distribution in User Agent #47409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
          🤖 GitHub commentsExpand to view the GitHub comments
 Just comment with: 
  | 
    
| 
           This pull request does not have a backport label. 
 To fixup this pull request, you need to add the backport labels for the needed 
  | 
    
        
          
                go.mod
              
                Outdated
          
        
      | github.com/meraki/dashboard-api-go/v3 => github.com/tommyers-elastic/dashboard-api-go/v3 v3.0.0-20250616163611-a325b49669a4 | ||
| ) | ||
| 
               | 
          ||
| replace github.com/elastic/elastic-agent-libs => github.com/ycombinator/elastic-agent-libs v0.0.0-20251030233529-00a787285e4a | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIXME: remove and bump version on github.com/elastic/elastic-agent-libs once elastic/elastic-agent-libs#366 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in b679ab1.
| 
           Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending removal of the replace directive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Requesting changes until https://github.com/elastic/beats/pull/47409/files#r2479832526 is completed to avoid an unintentional merging 😄
Proposed commit message
This PR includes whether the Beat is running from a FIPS distribution in the User Agent sent by Beats. This allows us to track FIPS usage for Beats.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesstresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
None.