-
Notifications
You must be signed in to change notification settings - Fork 5k
cleanup(otel): move otelbeat packages to x-pack/otel #47873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 GitHub commentsJust comment with:
|
61955a4 to
38a3c97
Compare
|
/test |
|
/test |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Some intermittent |
|
/test |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
@narph we will need someone from your team to review here please. |
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSI file changes LGTM
|
Moving to draft until I can fix the conflicts. |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
/test |
|
/test |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
There's something causing CI to break. The make -C x-pack/otel check && make check-no-changes
...
go: downloading github.com/Azure/go-autorest/autorest/validation v0.3.1
go: downloading github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c
go: downloading github.com/kylelemons/godebug v1.1.0
Exited with status -1 (agent lost)I ran the same command locally and it works, so I need to check which change in this PR caused the issue. |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Proposed commit message
Move the remaining otelbeat packages to x-pack/otel so that all otel-related code is centralized.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.How to test this PR locally
Related issues