Skip to content

Conversation

@mauri870
Copy link
Member

@mauri870 mauri870 commented Dec 2, 2025

Proposed commit message

Move the remaining otelbeat packages to x-pack/otel so that all otel-related code is centralized.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

How to test this PR locally

cd x-pack/filebeat
mage goIntegTest

cd x-pack/metricbeat
mage goIntegTest

Related issues

@mauri870 mauri870 self-assigned this Dec 2, 2025
@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-active-all Automated backport with mergify to all the active branches skip-changelog labels Dec 2, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mauri870 mauri870 force-pushed the rellocate-xpack-otel branch from 61955a4 to 38a3c97 Compare December 3, 2025 11:20
@mauri870
Copy link
Member Author

mauri870 commented Dec 3, 2025

/test

@mauri870
Copy link
Member Author

mauri870 commented Dec 3, 2025

/test

@mauri870 mauri870 marked this pull request as ready for review December 3, 2025 12:55
@mauri870 mauri870 requested review from a team as code owners December 3, 2025 12:55
@mauri870 mauri870 requested review from VihasMakwana and faec December 3, 2025 12:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870
Copy link
Member Author

mauri870 commented Dec 3, 2025

Some intermittent agent lost failures are occurring in CI. It seems to be a widespread issue on Buildkite.

@mauri870
Copy link
Member Author

mauri870 commented Dec 3, 2025

/test

@pierrehilbert pierrehilbert added the Team:Security-Service Integrations Security Service Integrations Team label Dec 4, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@pierrehilbert
Copy link
Contributor

@narph we will need someone from your team to review here please.

@mauri870 mauri870 requested a review from cmacknz December 4, 2025 11:44
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSI file changes LGTM

@mauri870
Copy link
Member Author

mauri870 commented Dec 9, 2025

Moving to draft until I can fix the conflicts.

@mauri870 mauri870 marked this pull request as draft December 9, 2025 14:55
@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rellocate-xpack-otel upstream/rellocate-xpack-otel
git merge upstream/main
git push upstream rellocate-xpack-otel

@mauri870
Copy link
Member Author

/test

@mauri870
Copy link
Member Author

/test

@mergify
Copy link
Contributor

mergify bot commented Dec 11, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rellocate-xpack-otel upstream/rellocate-xpack-otel
git merge upstream/main
git push upstream rellocate-xpack-otel

@mauri870
Copy link
Member Author

There's something causing CI to break. The x-pack/otel: run check step normally takes less than six minutes, but it's losing the agent around the 19-minute mark:

make -C x-pack/otel check && make check-no-changes
...
go: downloading github.com/Azure/go-autorest/autorest/validation v0.3.1
go: downloading github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c
go: downloading github.com/kylelemons/godebug v1.1.0
Exited with status -1 (agent lost)

I ran the same command locally and it works, so I need to check which change in this PR caused the issue.

@mergify
Copy link
Contributor

mergify bot commented Dec 16, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rellocate-xpack-otel upstream/rellocate-xpack-otel
git merge upstream/main
git push upstream rellocate-xpack-otel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Service Integrations Security Service Integrations Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants