feat: add resource pool id to vSphere's cluster metricset

[stefans-elastic]

Proposed commit message

See title

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
• I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

Author's Checklist

• [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

[github-actions]

🤖 GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @stefans-elastic? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
• backport-active-all is the label that automatically backports to all active branches.
• backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
• backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

[github-actions]

🔍 Preview links for changed docs

• docs/reference/metricbeat/exported-fields-vsphere.md

[colleenmcginnis]

Based on the lack of backport labels, I assume this change is going into the next minor version. If that's not correct, feel free to adjust. You'll need to regenerate the docs after making this change.

[stefans-elastic]

@ishleenk17 I would like to ask your opinion on which versions do you think this should be backported to? backport-active-9 ?

[ishleenk17]

@ishleenk17 I would like to ask your opinion on which versions do you think this should be backported to? backport-active-9 ?

Since its a new metric support, I would be ok to have it backported to active-9.x

[ishleenk17]

@ishleenk17 I would like to ask your opinion on which versions do you think this should be backported to? backport-active-9 ?

Since its a new metric support, I would be ok to have it backported to active-9.x

@colleenmcginnis : Would the label 9.3 change in case we are backporting ?

[colleenmcginnis]

@colleenmcginnis : Would the label 9.3 change in case we are backporting ?

Yes. You should update the version number in metricbeat/module/vsphere/cluster/_meta/fields.yml to the earliest version it is being added to.

[stefans-elastic]

@colleenmcginnis : Would the label 9.3 change in case we are backporting ?

Yes. You should update the version number in metricbeat/module/vsphere/cluster/_meta/fields.yml to the earliest version it is being added to.

if I'm reading release schedule correctly the value should be 9.1.10, is it correct?

[github-actions]

@Mergifyio backport 9.1 9.2

[mergify]

backport 9.1 9.2

✅ Backports have been created

Details

• #48083 [9.1](backport #47883) feat: add resource pool id to vSphere's cluster metricset has been created for branch 9.1
• #48082 [9.2](backport #47883) feat: add resource pool id to vSphere's cluster metricset has been created for branch 9.2