-
Notifications
You must be signed in to change notification settings - Fork 5k
[metricbeat/zookeeper] Fix potential panics and remove unused code in server module #47915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shmsr
wants to merge
3
commits into
elastic:main
Choose a base branch
from
shmsr:fix-zookeeper-panic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+117
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests - Add bounds checking for version and date regex matches to prevent index-out-of-range panics on specific input - Fix off-by-one error in mode split check (< 1 → < 2) - Remove unused regex variables (ipCapturer, thatNumberCapturer, portCapturer, dataCapturer) - Add TestParseSrvrEdgeCases with table-driven tests for edge cases
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Member
Author
|
@mykola-elastic Could you please review this as well? |
ishleenk17
reviewed
Dec 10, 2025
ishleenk17
approved these changes
Dec 10, 2025
mykola-elastic
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR improves the robustness of the Zookeeper server by adding proper bounds checking to prevent potential index-out-of-range panics, removes unused regex variables, and adds test coverage for edge cases.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.