-
Notifications
You must be signed in to change notification settings - Fork 5k
[metricbeat/graphite] Fix out-of-bounds panic in graphite server metric processing #47916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shmsr
wants to merge
5
commits into
elastic:main
Choose a base branch
from
shmsr:fix-graphite-panic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+180
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plate Apply Add bounds check in template.Apply() to prevent index out of range panic when incoming metrics have fewer parts than the template expects.
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
mykola-elastic
approved these changes
Dec 9, 2025
orestisfl
approved these changes
Dec 10, 2025
ishleenk17
approved these changes
Dec 10, 2025
rdner
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Team:Obs-InfraObs
Label for the Observability Infrastructure Monitoring team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Fixes a potential panic in the graphite server metricset when processing metrics with fewer parts than the configured template expects.
The
template.Apply()function iterated over template parts and accessedparts[i]without verifying that the index was within bounds. When a metric had fewer segments than the template, this caused an index out of range panic. Now the patch handles this by adding a bounds check at the start of the loop iteration.Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.