x-pack/filebeat/input/awss3: Add lexicographical polling mode#48310
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
🔍 Preview links for changed docs |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
@kcreddy thanks again for the update and working on this.
I left few more remarks and we are almost there 🙌
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
Overall looks good, but please check the current lint failures to get a green build - https://github.com/elastic/beats/actions/runs/21706571563/job/62599113313?pr=48310#step:5:38
|
The remaining lint complaints are all "Error return value is not checked (errcheck)". This because of this. I do not believe that option should be true; there are numerous cases (for example to cases that are flagged here) where a direct panic from ( |
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
I have this concern which must be checked and added - #48310 (comment)
Otherwise, my local run went fine and I can clearly see the benefit of this feature. I am approving to unblock once above concern is fixed.
Proposed commit message
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
How to test this PR locally
Related issues
Use cases