Remove use of github.com/elastic/elastic-agent-client from OSS Beats#48353
Merged
cmacknz merged 10 commits intoJan 15, 2026
Conversation
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
🤖 GitHub commentsJust comment with:
|
1c64e1f to
0061bde
Compare
kruskall
approved these changes
Jan 9, 2026
mauri870
approved these changes
Jan 12, 2026
andrewkroh
approved these changes
Jan 15, 2026
Contributor
|
@Mergifyio backport 8.19 9.1 9.2 9.3 |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Jan 15, 2026
…48353) * Remove elastic-agent-client import for useragent. * Remove elastic-agent-client from manager interface. * Remove use of elastic-agent-client in features. * Move cloned types to separate file. * Add changelog. * Add depguard rule to forbid future use. * Fix OtelManager * Fix osquerybeat tests * Run mage fmt * Fix lint warning: remove unnecessary cast (cherry picked from commit adc57ca) # Conflicts: # libbeat/beat/beat.go # libbeat/beat/beat_test.go # x-pack/osquerybeat/beater/osquerybeat_status_test.go
mergify Bot
pushed a commit
that referenced
this pull request
Jan 15, 2026
…48353) * Remove elastic-agent-client import for useragent. * Remove elastic-agent-client from manager interface. * Remove use of elastic-agent-client in features. * Move cloned types to separate file. * Add changelog. * Add depguard rule to forbid future use. * Fix OtelManager * Fix osquerybeat tests * Run mage fmt * Fix lint warning: remove unnecessary cast (cherry picked from commit adc57ca) # Conflicts: # x-pack/osquerybeat/beater/osquerybeat_status_test.go
mergify Bot
pushed a commit
that referenced
this pull request
Jan 15, 2026
…48353) * Remove elastic-agent-client import for useragent. * Remove elastic-agent-client from manager interface. * Remove use of elastic-agent-client in features. * Move cloned types to separate file. * Add changelog. * Add depguard rule to forbid future use. * Fix OtelManager * Fix osquerybeat tests * Run mage fmt * Fix lint warning: remove unnecessary cast (cherry picked from commit adc57ca) # Conflicts: # x-pack/osquerybeat/beater/osquerybeat_status_test.go
mergify Bot
pushed a commit
that referenced
this pull request
Jan 15, 2026
…48353) * Remove elastic-agent-client import for useragent. * Remove elastic-agent-client from manager interface. * Remove use of elastic-agent-client in features. * Move cloned types to separate file. * Add changelog. * Add depguard rule to forbid future use. * Fix OtelManager * Fix osquerybeat tests * Run mage fmt * Fix lint warning: remove unnecessary cast (cherry picked from commit adc57ca)
cmacknz
added a commit
that referenced
this pull request
Jan 15, 2026
…t-client from OSS Beats (#48433) * Remove use of github.com/elastic/elastic-agent-client from OSS Beats (#48353) * Remove elastic-agent-client import for useragent. * Remove elastic-agent-client from manager interface. * Remove use of elastic-agent-client in features. * Move cloned types to separate file. * Add changelog. * Add depguard rule to forbid future use. * Fix OtelManager * Fix osquerybeat tests * Run mage fmt * Fix lint warning: remove unnecessary cast (cherry picked from commit adc57ca) # Conflicts: # libbeat/beat/beat.go # libbeat/beat/beat_test.go # x-pack/osquerybeat/beater/osquerybeat_status_test.go * Resolve conflicts * Remove file added by merge conflict --------- Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
cmacknz
added a commit
that referenced
this pull request
Jan 15, 2026
…-client from OSS Beats (#48434) * Remove use of github.com/elastic/elastic-agent-client from OSS Beats (#48353) * Remove elastic-agent-client import for useragent. * Remove elastic-agent-client from manager interface. * Remove use of elastic-agent-client in features. * Move cloned types to separate file. * Add changelog. * Add depguard rule to forbid future use. * Fix OtelManager * Fix osquerybeat tests * Run mage fmt * Fix lint warning: remove unnecessary cast (cherry picked from commit adc57ca) # Conflicts: # x-pack/osquerybeat/beater/osquerybeat_status_test.go * Resolve conflicts --------- Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
cmacknz
added a commit
that referenced
this pull request
Jan 15, 2026
…48353) (#48436) * Remove elastic-agent-client import for useragent. * Remove elastic-agent-client from manager interface. * Remove use of elastic-agent-client in features. * Move cloned types to separate file. * Add changelog. * Add depguard rule to forbid future use. * Fix OtelManager * Fix osquerybeat tests * Run mage fmt * Fix lint warning: remove unnecessary cast (cherry picked from commit adc57ca) Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
cmacknz
added a commit
that referenced
this pull request
Jan 19, 2026
…-client from OSS Beats (#48435) * Remove use of github.com/elastic/elastic-agent-client from OSS Beats (#48353) * Remove elastic-agent-client import for useragent. * Remove elastic-agent-client from manager interface. * Remove use of elastic-agent-client in features. * Move cloned types to separate file. * Add changelog. * Add depguard rule to forbid future use. * Fix OtelManager * Fix osquerybeat tests * Run mage fmt * Fix lint warning: remove unnecessary cast (cherry picked from commit adc57ca) # Conflicts: # x-pack/osquerybeat/beater/osquerybeat_status_test.go * Fix conflict --------- Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported that the OSS Beats had linked in elastic-agent-client which is ELv2 licensed, which was accurate as we were using types from it in a few places. Cloning a few trivial types (and Apache licensing them which is of no consequence) and minor moves of code fixes this and removes the elastic-agent-client dependency from the OSS code.
To verify:
When the Beat receivers project concludes, we should be able to completely remove or majorly reduce use of elastic-agent-client since it would be necessary anymore.
In the meantime, a new lint rule to flag use of this import outside of x-pack has been added.