[9.3](backport #43933) x-pack/filebeat/input/salesforce: Add optional token_url support for JWT Bearer Flow authentication#48471
Open
mergify[bot] wants to merge 6 commits into9.3from
Open
[9.3](backport #43933) x-pack/filebeat/input/salesforce: Add optional token_url support for JWT Bearer Flow authentication#48471mergify[bot] wants to merge 6 commits into9.3from
token_url support for JWT Bearer Flow authentication#48471mergify[bot] wants to merge 6 commits into9.3from
Conversation
6 tasks
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
Author
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @shmsr? 🙏 |
Resolve merge conflict in go.mod: - Keep newer go-sfdc for token_url feature - Keep mito v1.24.1 from 9.3 branch
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @shmsr? 🙏 |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @shmsr? 🙏 |
1 similar comment
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @shmsr? 🙏 |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @shmsr? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR adds optional support for a separate
token_urlconfiguration in the Salesforce input's JWT Bearer Flow authentication.Currently, when using JWT authentication in the Salesforce integration, the
urlconfiguration is used for both:aud) in the JWTHowever, some users have custom Salesforce domains or have disabled logins for the default endpoints (
https://login.salesforce.comorhttps://test.salesforce.com). In these cases, the audience URL and the token endpoint URL need to be different.The new optional configuration is:
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Related issues
This is an automatic backport of pull request x-pack/filebeat/input/salesforce: Add optional
token_urlsupport for JWT Bearer Flow authentication #43933 done by Mergify.