[otel] add kafka partitioner extension#50226
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This comment has been minimized.
This comment has been minimized.
50c4f5e to
9ea289a
Compare
This comment has been minimized.
This comment has been minimized.
a6569c2 to
6e2212b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
277a5d1 to
0959ca0
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
92f9be5 to
8259f66
Compare
This comment has been minimized.
This comment has been minimized.
TL;DRThe failures are mixed: one confirmed CI environment issue ( Remediation
Investigation detailsRoot Cause
Relevant code paths:
Evidence
Verification
Follow-up
Note 🔒 Integrity filter blocked 2 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
Force merging, test failures are unrelated. |
* [otel] add kafka partitioner extension (#50226) * chore: add partitioner extension * fix go.mod * notice * tests and fix start sequence * goimports * type * respect dropFail * add reachable_only support * deduplicate * test * partition --------- Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co> (cherry picked from commit 035b4bb) # Conflicts: # NOTICE.txt # go.mod * Fix conflicts * Fix another conflict --------- Co-authored-by: Vihas Makwana <121151420+VihasMakwana@users.noreply.github.com> Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
* chore: add partitioner extension * fix go.mod * notice * tests and fix start sequence * goimports * type * respect dropFail * add reachable_only support * deduplicate * test * partition --------- Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
* chore: add partitioner extension * fix go.mod * notice * tests and fix start sequence * goimports * type * respect dropFail * add reachable_only support * deduplicate * test * partition --------- Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
* chore: add partitioner extension * fix go.mod * notice * tests and fix start sequence * goimports * type * respect dropFail * add reachable_only support * deduplicate * test * partition --------- Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
* chore: add partitioner extension * fix go.mod * notice * tests and fix start sequence * goimports * type * respect dropFail * add reachable_only support * deduplicate * test * partition --------- Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Proposed commit message
This PR adds a new extension for partitioning kakfa records. This extension will work with existing config.
The extension follows upstream
RecordPartitionerExtension(See here), which is used to return underlying partition.Ideally, we should use same logic as https://github.com/elastic/beats/blob/main/libbeat/outputs/kafka/partition.go, but upstream exporter uses https://pkg.go.dev/github.com/twmb/franz-go/pkg/kgo and beats uses sarama library and these two differ in terms of interfaces. Hence, the duplication.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.How to test this PR
otelmode for the output.