[9.3](backport #49838) idxmgmt: remove redundant beatPaths parameter

[mergify]

Proposed commit message

idxmgmt: remove redundant beatPaths parameter

NewESClientHandler and NewFileClientHandler accepted both beat.Info
and *paths.Path. Now that Info carries Paths, drop the separate
argument and pass info.Paths to the downstream template loaders.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works.
• I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

None. Internal API change only.

How to test this PR locally

Related issues

• Relates [beatreceiver] move paths object into Beat.Info #49803
• Blocked by Move Paths from beat.Beat to beat.Info #49836

  ---

  This is an automatic backport of pull request idxmgmt: remove redundant beatPaths parameter #49838 done by Mergify.

[mergify]

Cherry-pick of 8b7236f has failed:

On branch mergify/bp/9.3/pr-49838
Your branch is up to date with 'origin/9.3'.

You are currently cherry-picking commit 8b7236f25.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   libbeat/idxmgmt/client_handler.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   libbeat/cmd/export/ilm_policy.go
	both modified:   libbeat/cmd/export/template.go
	both modified:   libbeat/cmd/instance/beat.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[github-actions]

🤖 GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
• /test : Run the Buildkite pipeline.

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[github-actions]

TL;DR

Buildkite is failing for all affected pipelines because this backport branch still contains unresolved merge-conflict markers in libbeat/cmd/*, and after resolving those, the backported idxmgmt change still references info.Paths on 9.3 where beat.Info does not expose that field. Resolve the conflict hunks and keep the 9.3-compatible path handling to unblock CI.

Remediation

• Resolve conflict markers in:
  • libbeat/cmd/export/ilm_policy.go
  • libbeat/cmd/export/template.go
  • libbeat/cmd/instance/beat.go
• For 9.3 compatibility, do not use info.Paths in libbeat/idxmgmt/client_handler.go; keep/use explicit beat paths argument (or equivalent 9.3-compatible source) because beat.Info on this branch does not provide Paths.
• Re-run the failing steps (Run pre-commit, Run check/update) after the above edits.

Investigation details

Root Cause

The failures are code-level and come from an incomplete/conflicting backport state:

1. Unresolved merge conflicts in PR files (detected by pre-commit and go parser):

   • libbeat/cmd/export/ilm_policy.go:48,50,52
   • libbeat/cmd/export/template.go:50,52,54
   • libbeat/cmd/instance/beat.go:693,695,697,1141,1143,1145

2. API mismatch on 9.3 after applying idxmgmt signature changes:

   • libbeat/idxmgmt/client_handler.go now uses info.Paths
   • Build logs show compile/vet errors:
     • ../libbeat/idxmgmt/client_handler.go:67:75: info.Paths undefined (type beat.Info has no field or method Paths)
     • ../libbeat/idxmgmt/client_handler.go:81:111: info.Paths undefined (type beat.Info has no field or method Paths)

Evidence

• Build: https://buildkite.com/elastic/beats/builds/44602
• Job/step examples:
  • Packetbeat: Run pre-commit
  • Packetbeat: Run check/update
  • Libbeat: Run check/update
• Key log excerpts:
  • check for merge conflicts...Failed
  • libbeat/cmd/export/ilm_policy.go:48: Merge conflict string '<<<<<<<' found
  • cmd/export/ilm_policy.go:48:1: expected statement, found '<<'
  • ../libbeat/idxmgmt/client_handler.go:67:75: info.Paths undefined (type beat.Info has no field or method Paths)

Verification

• Not run locally in this workflow context; conclusions are from Buildkite job logs plus PR branch file inspection.

Follow-up

If helpful, cherry-pick only the conflict-resolved, 9.3-compatible variant of this change (without the beat.Info.Paths dependency) and rerun /test.

---

What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

[mergify]

This pull request has not been merged yet. Could you please review and merge it @orestisfl? 🙏

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/9.3/pr-49838 upstream/mergify/bp/9.3/pr-49838
git merge upstream/9.3
git push upstream mergify/bp/9.3/pr-49838

[orestisfl]

Backport, build verified locally after merging upstream/9.3

[github-actions]

TL;DR

golangci-lint failed in lint (ubuntu-latest) on forbidigo violations introduced in libbeat/cmd/instance/beat.go (use of logp.NewLogger, paths.Paths, and paths.InitPaths). Replace those with the branch-approved patterns and rerun the lint workflow.

Remediation

• Update libbeat/cmd/instance/beat.go to remove forbidden APIs:
  • libbeat/cmd/instance/beat.go:188 (logp.NewLogger(...))
  • libbeat/cmd/instance/beat.go:770 (paths.Paths)
  • libbeat/cmd/instance/beat.go:1510 (paths.InitPaths(...))
• Re-run golangci-lint (or rerun the failed workflow run) after applying those edits.

Investigation details

Root Cause

The failing step is golangci-lint in job lint (ubuntu-latest). Lint fails on forbidigo checks in libbeat/cmd/instance/beat.go, so the job exits with issues found.

Evidence

• Workflow: https://github.com/elastic/beats/actions/runs/25051535617
• Job/step: lint (ubuntu-latest) / golangci-lint
• Key log excerpt:
  • ##[error]libbeat/cmd/instance/beat.go:188:5: use of \logp.NewLogger` forbidden because "accept a *logp.Logger as a parameter instead of creating one with logp.NewLogger" (forbidigo)`
  • ##[error]libbeat/cmd/instance/beat.go:769:17: use of \paths.Paths` forbidden because "use a per-beat *paths.Path instance instead of the global paths.Paths" (forbidigo)`
  • ##[error]libbeat/cmd/instance/beat.go:1509:12: use of \paths.InitPaths` forbidden because "use a per-beat *paths.Path instance instead of the global paths.InitPaths" (forbidigo)`
  • ##[error]issues found

Validation

• Not run locally in this workflow context; diagnosis is based on the failed job logs for run 25051535617.

Follow-up

The previous detective report on this PR flagged a different failure (info.Paths undefined). This run is a new/later failure class (forbidigo) and needs the API usage cleanup above.

---

What is this? | From workflow: PR Actions Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.