[9.4](backport #50980) Fix filebeat test_shutdown_wait_ok#50985
Open
mergify[bot] wants to merge 1 commit into
Open
[9.4](backport #50980) Fix filebeat test_shutdown_wait_ok#50985mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
(cherry picked from commit 73c48e4)
|
This pull request doesn't have a |
Contributor
🤖 GitHub commentsJust comment with:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
With the fix merged from #50625 it results in all events being removed from the pipeline on shutdown. Then this test didn't set the correct settings to prevent file rotation that would cause the test to fail. With both the change in this PR and the race condition fix this test can be re-enabled.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesstresstest.shscript to run them under stress conditions and race detector to verify their stability.[ ] I have added an entry in./changelog/fragmentsusing the changelog tool.Disruptive User Impact
None
How to test this PR locally
Run unit tests.
Related issues
This is an automatic backport of pull request Fix filebeat test_shutdown_wait_ok #50980 done by Mergify.