[beatreceiver] Add e2e tests for tcp and udp inputs#51705
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
📝 WalkthroughWalkthroughThis PR adds a new integration test file for Filebeat, Changes
Suggested labels: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@x-pack/filebeat/tests/integration/otel_tcp_udp_test.go`:
- Around line 217-226: The UDP readiness check in the otel_tcp_udp test is a
no-op because net.Dial on UDP does not confirm the receiver is bound, so update
the readiness logic in TestUDPInputOTelE2E to wait for a log message that proves
the UDP listener started. Replace the current require.EventuallyWithTf probe
around the net.Dial call with a log-based wait such as WaitLogsContainsAnyOrder,
using the existing otelAddress/inputType context to target the OTel UDP input
startup signal before launching runClient.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 0db0cd8c-ff02-46e0-9f7c-f9eaaab23a0e
⛔ Files ignored due to path filters (1)
x-pack/filebeat/test.logis excluded by!**/*.log
📒 Files selected for processing (1)
x-pack/filebeat/tests/integration/otel_tcp_udp_test.go
Proposed commit message
This PR adds e2e test that compares document ingested by tcp and udp input in standalone and otel mode.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
None
How to test this PR locally
Related issues