auditbeat: Update to quark 0.6.0#51767
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e955fc1 to
60f3c5d
Compare
|
this is the current ECS for a simple ls: |
TL;DR
Remediation
Investigation detailsRoot CauseThis is a generated/formatting drift, not a quark runtime test failure. The The stale PR-head line is: "process.pid": uint32(os.Getpid()), (nolint/redacted):gosec
"process.pid": uint32(os.Getpid()), (nolint/redacted):gosecEvidence
Local reproduction on PR head produced the same formatter diff: diff --git a/x-pack/auditbeat/module/system/process/quark_provider_linux_test.go b/x-pack/auditbeat/module/system/process/quark_provider_linux_test.go
@@ -258,7 +258,7 @@ func makeSelfEvent(t *testing.T, qp quark.Process, be backend) mb.Event {
"process.name": qp.Comm,
"process.args": qp.Cmdline,
"process.args_count": len(qp.Cmdline),
- "process.pid": uint32(os.Getpid()), (nolint/redacted):gosec
+ "process.pid": uint32(os.Getpid()), (nolint/redacted):gosec
"process.executable": exe,
"process.parent.pid": uint32(os.Getppid()), (nolint/redacted):gosec
"process.start": time.Unix(0, int64(qp.Proc.TimeBoot)),Verification
Follow-up
What is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a6cf99b to
23170fd
Compare
TL;DR
Remediation
Investigation detailsRoot CauseThe PR has already fixed the earlier broader lint failures, but the current Evidence
The latest prior PR Actions Detective comments covered earlier Validation
Follow-up
What is this? | From workflow: PR Actions Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
287d47b to
dee8fee
Compare
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
Mostly keeping track of API changes, while here add some more members to the metrics.
|
Tick the box to add this pull request to the merge queue (same as
|
Proposed commit message
Mostly keeping track of API changes, while here add some more members to the
metrics.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works. Where relevant, I have used thestresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Related issues