[9.5](backport #51793) filestream: default include_file_fingerprint to true#51839
Merged
Conversation
Soft-revert of #50129, which made log.file.fingerprint in published events opt-in via include_file_fingerprint (default false). Removing the field by default is technically a breaking change that we don't understand fully yet. Users who want to save network, indexing, and storage costs at scale can set include_file_fingerprint to false. A still-growing fingerprint is never published. After further benchmarks we can re-consider if we want to make the breaking change and flip the default to false. Reclassify the changelog fragment from breaking-change to enhancement. (cherry picked from commit 8e39946)
Contributor
🤖 GitHub commentsJust comment with:
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
🔍 Preview links for changed docs |
Contributor
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
orestisfl
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
None. This PR removes a disruption rather than introducing one.
How to test this PR locally
Integration test
Asserts
log.file.fingerprintis present by default, present withinclude_file_fingerprint: true, and absent withfalse:go test -v -tags integration -count=1 -run TestFilestreamIncludeFileFingerprint ./filebeat/tests/integration/A still-growing fingerprint is never published (regardless of the flag)
A file smaller than the fingerprint length is tracked via a growing fingerprint whose SHA-256 is not yet computed, so
log.file.fingerprintmust never be added to its events even wheninclude_file_fingerprint: true. Reproduced end to end with the real binary and real config:Config at
/tmp/fp/fb.yml(varypathsbetween the two input dirs andinclude_file_fingerprintbetweentrue/falseacross the four runs):Run each combination and count events carrying the field:
Observed:
include_file_fingerprintlog.file.fingerprinttruefalsetruefalseThe growing file never carries
log.file.fingerprintunder either flag, while the complete file carries it only when the flag istrue. Samplelog.filefor the growing input withinclude_file_fingerprint: true(nofingerprintkey):{"device_id":"36","inode":"1512763","path":"/tmp/fp/in-growing/small.log"}Sample
log.filefor the complete input withinclude_file_fingerprint: true(fingerprintpresent):{"device_id":"36","fingerprint":"bab6a068cc46b9059ae1fa1b654cbc4dff7b4adca3866854d4b2b31058074e79","inode":"1512764","path":"/tmp/fp/in-complete/big.log"}Related issues
This is an automatic backport of pull request #51793 done by [Mergify](https://mergify.com).