Skip to content

merge queue: checking 9.5 (a67a106) and #51937 together#51943

Closed
mergify[bot] wants to merge 2 commits into
9.5from
mergify/merge-queue/9c7756989c
Closed

merge queue: checking 9.5 (a67a106) and #51937 together#51943
mergify[bot] wants to merge 2 commits into
9.5from
mergify/merge-queue/9c7756989c

Conversation

@mergify

@mergify mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

✨ Merge queue reset: an external action moved the base branch head to e892816. The pull request #51937 has been requeued. ✨

Branch 9.5 (a67a106) and #51937 are queued together for merge.

This pull request has been created by Mergify to check the mergeability of #51937.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

Required conditions to stay in the queue:

---
checking_base_sha: a67a1061a0de93c1cb8089ddb9803d1e5ab6fc73
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 51937
    scopes: []
scopes: []
...

github-actions Bot and others added 2 commits July 14, 2026 15:41
Made with ❤️️ by updatecli
@github-actions

Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • /test : Run the Buildkite pipeline.

@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2026
@botelastic

botelastic Bot commented Jul 14, 2026

Copy link
Copy Markdown

This pull request doesn't have a Team:<team> label.

@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Merge queue reset: an external action moved the base branch head to e892816

@mergify mergify Bot closed this Jul 14, 2026
@mergify mergify Bot deleted the mergify/merge-queue/9c7756989c branch July 14, 2026 17:47
@github-actions

Copy link
Copy Markdown
Contributor

TL;DR

The Buildkite failure is an isolated timeout in x-pack/filebeat/input/streaming/TestFollowStreamReturnsOnCancelWithStalledServer, while waiting for its first published event. The merge-queue change in #51937 only updates testing/environments/snapshot.yml; it does not touch this test or websocket implementation, so this failure is not attributable to that PR. A retry is appropriate.

Remediation

  • Retry the Buildkite build; the failing test passed 10 consecutive scoped runs locally.
  • Separately fix the FIPS-only target wiring in x-pack/filebeat/magefile.go:184-190 to use devtools.FIPSOnlyGoTestIntegrationFromHostArgs(ctx), while retaining the admin credential overrides. The current code uses DefaultGoTestIntegrationFromHostArgs, so it does not set the GODEBUG=fips140=only promised by the target comment.
Investigation details

Root Cause

The observed failure is a test failure consistent with transient scheduling/flakiness: the test timed out at x-pack/filebeat/input/streaming/websocket_test.go:95 before receiving the first event. The test itself and the websocket implementation were unchanged by the merge commit. The FIPS target also has an independent configuration defect: x-pack/filebeat/magefile.go:185 constructs default test arguments, whereas dev-tools/mage/gotest.go:231-242 provides the FIPS-specific arguments and sets GODEBUG=fips140=only,tlsmlkem=0.

Evidence

Verification

  • Ran go test -count=1 -run '^TestFollowStreamReturnsOnCancelWithStalledServer$' ./input/streaming: passed.
  • Repeated the same test 10 times with -count=10: passed.
  • Ran with GODEBUG=fips140=only: the test correctly skips via testing/testutils/skipFIPS140.go:26-34.

What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants