[9.3](backport #51940) Set shutdown timeout for beat receivers to 5s by default

[mergify]

Proposed commit message

Set shutdown timeout for beat receivers to 5s by default.

Beat receivers need a longer timeout than the default 1s, as it needs to exceed the batcher flush timeout. The current code gives the impression of this already happening, but in reality, if the beater handles pipeline shutdown on its own, the default timeout wins.

The PR adds the default in NewBeatForReceiver and adds a test for filebeat receiver which asserts that the timeout is at least 5 seconds.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
• [ ] I have added an entry in ./changelog/fragments using the changelog tool.

Related issues

• Relates [Flaky Test] Fix TestMonitoringNoDuplicates flakiness elastic-agent#15514

---

This is an automatic backport of pull request #51940 done by [Mergify](https://mergify.com).

[github-actions]

🤖 GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
• /test : Run the Buildkite pipeline.

[infra-vault-gh-plugin-prod]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[github-actions]

TL;DR

The beats-xpack-filebeat check fails during go vet because the backport adds TestShutdownDrainTimeout but does not include the NewFactoryWithSettings helper it calls. This is a backport completeness issue, not a transient Buildkite failure.

Remediation

• Backport the corresponding x-pack/filebeat/fbreceiver/factory.go change that defines NewFactoryWithSettings(Settings) and preserves NewFactory() as the no-argument wrapper, or adjust the test to construct the factory using the APIs available on 9.3.
• Re-run make -C x-pack/filebeat check update followed by make check-no-changes.

Investigation details

Root Cause

The failed job runs make -C x-pack/filebeat check update and go vet reports x-pack/filebeat/fbreceiver/receiver_test.go:764:13: undefined: NewFactoryWithSettings. The PR diff adds TestShutdownDrainTimeout in x-pack/filebeat/fbreceiver/receiver_test.go, where line 764 calls NewFactoryWithSettings(Settings{Home: tmpDir}), but the same diff does not modify x-pack/filebeat/fbreceiver/factory.go. At the PR commit, that factory file exposes NewFactory() only; it has no NewFactoryWithSettings declaration. The test therefore cannot compile on the 9.3 backport branch.

The shutdown-timeout implementation in x-pack/libbeat/cmd/instance/beat.go is unrelated to this compile error; the failure occurs before tests execute.

Evidence

• Build: https://buildkite.com/elastic/beats/builds/49443
• Job/step: x-pack/filebeat: Run check/update (https://buildkite.com/elastic/beats-xpack-filebeat/builds/34184)
• Key log excerpt: vet: fbreceiver/receiver_test.go:764:13: undefined: NewFactoryWithSettings
• PR: [9.3](backport #51940) Set shutdown timeout for beat receivers to 5s by default #51948

Verification

• Not run beyond the recorded CI job: compilation stops in go vet before the new test can execute.

---

What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.