Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 32 additions & 30 deletions NOTICE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14358,6 +14358,38 @@ See the License for the specific language governing permissions and
limitations under the License.


--------------------------------------------------------------------------------
Dependency : github.com/elastic/lumberjack
Version: v0.0.0-20260715013204-c5b60bbeaaab
Licence type (autodetected): MIT
--------------------------------------------------------------------------------

Contents of probable licence file $GOMODCACHE/github.com/elastic/lumberjack@v0.0.0-20260715013204-c5b60bbeaaab/LICENSE:

The MIT License (MIT)

Copyright (c) 2014 Nate Finch
Copyright (c) 2026 Elasticsearch B.V.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.


--------------------------------------------------------------------------------
Dependency : github.com/elastic/mito
Version: v1.23.2
Expand Down Expand Up @@ -30666,36 +30698,6 @@ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.


--------------------------------------------------------------------------------
Dependency : gopkg.in/natefinch/lumberjack.v2
Version: v2.2.1
Licence type (autodetected): MIT
--------------------------------------------------------------------------------

Contents of probable licence file $GOMODCACHE/gopkg.in/natefinch/lumberjack.v2@v2.2.1/LICENSE:

The MIT License (MIT)

Copyright (c) 2014 Nate Finch

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

--------------------------------------------------------------------------------
Dependency : gopkg.in/yaml.v2
Version: v2.4.0
Expand Down
3 changes: 3 additions & 0 deletions changelog/fragments/1784080439-49092-lumberjack.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: bug-fix
summary: Fix goroutine leak in request trace logging infrastructure.
component: filebeat
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ require (
go.uber.org/mock v0.5.0
golang.org/x/term v0.43.0
google.golang.org/genproto/googleapis/api v0.0.0-20260526163538-3dc84a4a5aaa
gopkg.in/natefinch/lumberjack.v2 v2.2.1
gopkg.in/yaml.v3 v3.0.1
)

Expand All @@ -236,6 +235,7 @@ require (
github.com/cilium/ebpf v0.21.0
github.com/coder/websocket v1.8.14
github.com/elastic/gokrb5/v8 v8.0.0-20251105095404-23cc45e6a102
github.com/elastic/lumberjack v0.0.0-20260715013204-c5b60bbeaaab
github.com/gorilla/mux v1.8.1
github.com/joeshaw/multierror v0.0.0-20140124173710-69b34d4ec901
github.com/mitchellh/gox v1.0.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,8 @@ github.com/elastic/gopacket v1.1.20-0.20241002174017-e8c5fda595e6 h1:VgOx6omXIMK
github.com/elastic/gopacket v1.1.20-0.20241002174017-e8c5fda595e6/go.mod h1:riddUzxTSBpJXk3qBHtYr4qOhFhT6k/1c0E3qkQjQpA=
github.com/elastic/gosigar v0.14.4 h1:7NRnWJDFjEKpOjnHhtzrPGZWr9EMrYFsLjF4q0Czosk=
github.com/elastic/gosigar v0.14.4/go.mod h1:tx91Eb3YgFk6y++h88fRAnxic3Si1ZDHooqnJU/hqo8=
github.com/elastic/lumberjack v0.0.0-20260715013204-c5b60bbeaaab h1:p33sNyLrsWoIoRFL3E6hKajacBbsHuST8xW7y7cxGzY=
github.com/elastic/lumberjack v0.0.0-20260715013204-c5b60bbeaaab/go.mod h1:t8v3y03G3KubyWgYqe+Jcxj/jDddnkp70743iSYrQiU=
github.com/elastic/mito v1.23.2 h1:cEtTsCdIoqglm1847b9NKu4HGImRcL4VA0exakfWCMw=
github.com/elastic/mito v1.23.2/go.mod h1:nmkKaLmNGWf79vthVZcNBvKZCAFCaxx4I1LcJ1+OAfU=
github.com/elastic/mock-es v0.0.0-20250530054253-8c3b6053f9b6 h1:JVNuBrmOoqLJgp9o68YBMnOrXCzQI3mCppW+suwRSlw=
Expand Down Expand Up @@ -1525,8 +1527,6 @@ gopkg.in/inf.v0 v0.9.1 h1:73M5CoZyi3ZLMOyDlQh031Cx6N9NDJ2Vvfl76EDAgDc=
gopkg.in/inf.v0 v0.9.1/go.mod h1:cWUDdTG/fYaXco+Dcufb5Vnc6Gp2YChqWtbxRZE0mXw=
gopkg.in/mcuadros/go-syslog.v2 v2.3.0 h1:kcsiS+WsTKyIEPABJBJtoG0KkOS6yzvJ+/eZlhD79kk=
gopkg.in/mcuadros/go-syslog.v2 v2.3.0/go.mod h1:l5LPIyOOyIdQquNg+oU6Z3524YwrcqEm0aKH+5zpt2U=
gopkg.in/natefinch/lumberjack.v2 v2.2.1 h1:bBRl1b0OH9s/DuPhuXpNl+VtCaJXFZ5/uEFST95x9zc=
gopkg.in/natefinch/lumberjack.v2 v2.2.1/go.mod h1:YD8tP3GAjkrDg1eZH7EGmyESg/lsYskCTPBJVb9jqSc=
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 h1:uRGJdciOHaEIrze2W8Q3AKkepLTh2hOroT7a+7czfdQ=
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7/go.mod h1:dt/ZhP58zS4L8KSrWDmTeBkI65Dw0HsyUHuEVlX15mw=
gopkg.in/yaml.v1 v1.0.0-20140924161607-9f9df34309c0/go.mod h1:WDnlLJ4WF5VGsH/HVa3CI79GS0ol3YnhVnKP89i0kNg=
Expand Down
2 changes: 1 addition & 1 deletion x-pack/filebeat/input/cel/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ import (
"regexp"
"time"

"gopkg.in/natefinch/lumberjack.v2"
"gopkg.in/yaml.v3"

"github.com/elastic/elastic-agent-libs/logp"
"github.com/elastic/elastic-agent-libs/transport/httpcommon"
"github.com/elastic/lumberjack"
"github.com/elastic/mito/lib"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
"go.elastic.co/ecszap"
"go.uber.org/zap"
"go.uber.org/zap/zapcore"
"gopkg.in/natefinch/lumberjack.v2"

"github.com/elastic/beats/v7/x-pack/filebeat/input/entityanalytics/internal/collections"
"github.com/elastic/beats/v7/x-pack/filebeat/input/entityanalytics/provider/azuread/authenticator"
Expand All @@ -33,6 +32,7 @@ import (
"github.com/elastic/elastic-agent-libs/mapstr"
"github.com/elastic/elastic-agent-libs/paths"
"github.com/elastic/elastic-agent-libs/transport/httpcommon"
"github.com/elastic/lumberjack"
)

const (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@
"github.com/gofrs/uuid/v5"
"github.com/google/go-cmp/cmp"
"github.com/stretchr/testify/require"
"gopkg.in/natefinch/lumberjack.v2"

"github.com/elastic/beats/v7/x-pack/filebeat/input/entityanalytics/internal/collections"
"github.com/elastic/beats/v7/x-pack/filebeat/input/entityanalytics/provider/azuread/authenticator/mock"
"github.com/elastic/beats/v7/x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher"
"github.com/elastic/elastic-agent-libs/config"
"github.com/elastic/elastic-agent-libs/logp"
"github.com/elastic/elastic-agent-libs/paths"
"github.com/elastic/lumberjack"
)

var trace = flag.Bool("request_trace", false, "enable request tracing during tests")
Expand Down Expand Up @@ -328,7 +328,7 @@
require.NoError(t, err)
auth := mock.New(mock.DefaultTokenValue)

f, err := New(context.Background(), t.Name(), c, logp.L(), auth, &paths.Path{Logs: t.TempDir()})

Check failure on line 331 in x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher/graph/graph_test.go

View workflow job for this annotation

GitHub Actions / lint (ubuntu-latest)

use of `logp.L` forbidden because "accept a *logp.Logger as a parameter instead of using the global logp.L()" (forbidigo)

Check failure on line 331 in x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher/graph/graph_test.go

View workflow job for this annotation

GitHub Actions / lint (windows-latest)

use of `logp.L` forbidden because "accept a *logp.Logger as a parameter instead of using the global logp.L()" (forbidigo)

Check failure on line 331 in x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher/graph/graph_test.go

View workflow job for this annotation

GitHub Actions / lint (macos-latest)

use of `logp.L` forbidden because "accept a *logp.Logger as a parameter instead of using the global logp.L()" (forbidigo)
require.NoError(t, err)

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
Expand Down Expand Up @@ -392,7 +392,7 @@
require.NoError(t, err)
auth := mock.New(mock.DefaultTokenValue)

f, err := New(context.Background(), t.Name(), c, logp.L(), auth, &paths.Path{Logs: t.TempDir()})

Check failure on line 395 in x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher/graph/graph_test.go

View workflow job for this annotation

GitHub Actions / lint (ubuntu-latest)

use of `logp.L` forbidden because "accept a *logp.Logger as a parameter instead of using the global logp.L()" (forbidigo)

Check failure on line 395 in x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher/graph/graph_test.go

View workflow job for this annotation

GitHub Actions / lint (windows-latest)

use of `logp.L` forbidden because "accept a *logp.Logger as a parameter instead of using the global logp.L()" (forbidigo)

Check failure on line 395 in x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher/graph/graph_test.go

View workflow job for this annotation

GitHub Actions / lint (macos-latest)

use of `logp.L` forbidden because "accept a *logp.Logger as a parameter instead of using the global logp.L()" (forbidigo)
require.NoError(t, err)

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
Expand Down Expand Up @@ -502,7 +502,7 @@
require.NoError(t, err)
auth := mock.New(mock.DefaultTokenValue)

f, err := New(context.Background(), t.Name(), c, logp.L(), auth, &paths.Path{Logs: t.TempDir()})

Check failure on line 505 in x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher/graph/graph_test.go

View workflow job for this annotation

GitHub Actions / lint (ubuntu-latest)

use of `logp.L` forbidden because "accept a *logp.Logger as a parameter instead of using the global logp.L()" (forbidigo)

Check failure on line 505 in x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher/graph/graph_test.go

View workflow job for this annotation

GitHub Actions / lint (windows-latest)

use of `logp.L` forbidden because "accept a *logp.Logger as a parameter instead of using the global logp.L()" (forbidigo)

Check failure on line 505 in x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher/graph/graph_test.go

View workflow job for this annotation

GitHub Actions / lint (macos-latest)

use of `logp.L` forbidden because "accept a *logp.Logger as a parameter instead of using the global logp.L()" (forbidigo)
require.NoError(t, err)

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@ import (
"errors"
"time"

"gopkg.in/natefinch/lumberjack.v2"

"github.com/elastic/elastic-agent-libs/transport/httpcommon"
"github.com/elastic/lumberjack"
)

// defaultConfig returns a default configuration.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@ import (
"testing"
"time"

"gopkg.in/natefinch/lumberjack.v2"

"github.com/elastic/elastic-agent-libs/config"
"github.com/elastic/elastic-agent-libs/transport/httpcommon"
"github.com/elastic/lumberjack"
)

var validateTests = []struct {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ import (

"github.com/gofrs/uuid/v5"
"github.com/google/go-cmp/cmp"
"gopkg.in/natefinch/lumberjack.v2"

"github.com/elastic/beats/v7/x-pack/filebeat/input/entityanalytics/provider/jamf/internal/jamf"
"github.com/elastic/elastic-agent-libs/logp"
"github.com/elastic/lumberjack"
)

var trace = flag.Bool("request_trace", false, "enable request tracing during tests")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@ import (
"strings"
"time"

"gopkg.in/natefinch/lumberjack.v2"

"github.com/elastic/elastic-agent-libs/transport/httpcommon"
"github.com/elastic/lumberjack"
)

// defaultConfig returns a default configuration.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@ import (
"testing"
"time"

"gopkg.in/natefinch/lumberjack.v2"

"github.com/elastic/elastic-agent-libs/config"
"github.com/elastic/elastic-agent-libs/transport/httpcommon"
"github.com/elastic/lumberjack"
)

var validateTests = []struct {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@
"testing"
"time"

"gopkg.in/natefinch/lumberjack.v2"

"github.com/elastic/beats/v7/x-pack/filebeat/input/entityanalytics/provider/okta/internal/okta"
"github.com/elastic/elastic-agent-libs/logp"
"github.com/elastic/lumberjack"
)

var trace = flag.Bool("request_trace", false, "enable request tracing during tests")
Expand Down Expand Up @@ -129,7 +128,7 @@
}
// Give the groups if this is a get user groups request.
userid := r.PathValue("userid")
fmt.Fprintln(w, strings.ReplaceAll(data[attr], "USERID", userid))

Check failure on line 131 in x-pack/filebeat/input/entityanalytics/provider/okta/okta_test.go

View workflow job for this annotation

GitHub Actions / lint (ubuntu-latest)

G705: XSS via taint analysis (gosec)

Check failure on line 131 in x-pack/filebeat/input/entityanalytics/provider/okta/okta_test.go

View workflow job for this annotation

GitHub Actions / lint (windows-latest)

G705: XSS via taint analysis (gosec)

Check failure on line 131 in x-pack/filebeat/input/entityanalytics/provider/okta/okta_test.go

View workflow job for this annotation

GitHub Actions / lint (macos-latest)

G705: XSS via taint analysis (gosec)
}))
mux.Handle("/api/v1/devices/{deviceid}/users", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
setHeaders(w)
Expand Down
3 changes: 1 addition & 2 deletions x-pack/filebeat/input/http_endpoint/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ import (
"net/textproto"
"strings"

"gopkg.in/natefinch/lumberjack.v2"

"github.com/elastic/elastic-agent-libs/transport/tlscommon"
"github.com/elastic/lumberjack"
)

// Available providers for CRC validation (use lowercase)
Expand Down
2 changes: 1 addition & 1 deletion x-pack/filebeat/input/http_endpoint/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import (

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gopkg.in/natefinch/lumberjack.v2"

confpkg "github.com/elastic/elastic-agent-libs/config"
"github.com/elastic/lumberjack"
)

func Test_validateConfig(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/filebeat/input/http_endpoint/handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gopkg.in/natefinch/lumberjack.v2"

"github.com/elastic/beats/v7/libbeat/beat"
"github.com/elastic/beats/v7/testing/testutils"
"github.com/elastic/elastic-agent-libs/logp"
"github.com/elastic/elastic-agent-libs/mapstr"
"github.com/elastic/elastic-agent-libs/monitoring"
"github.com/elastic/lumberjack"
)

var withTraces = flag.Bool("log-traces", false, "specify logging request traces during tests")
Expand All @@ -37,7 +37,7 @@
const traceLogsDir = "trace_logs"

func Test_httpReadJSON(t *testing.T) {
log := logp.NewLogger("http_endpoint_test")

Check failure on line 40 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (ubuntu-latest)

use of `logp.NewLogger` forbidden because "accept a *logp.Logger as a parameter instead of creating one with logp.NewLogger" (forbidigo)

Check failure on line 40 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (windows-latest)

use of `logp.NewLogger` forbidden because "accept a *logp.Logger as a parameter instead of creating one with logp.NewLogger" (forbidigo)

Check failure on line 40 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (macos-latest)

use of `logp.NewLogger` forbidden because "accept a *logp.Logger as a parameter instead of creating one with logp.NewLogger" (forbidigo)

tests := []struct {
name string
Expand Down Expand Up @@ -599,7 +599,7 @@
}
pub := new(publisher)
metrics := newInputMetrics(monitoring.NewRegistry(), logp.NewNopLogger())
apiHandler := newHandler(ctx, newTracerConfig(tc.name, tc.conf, *withTraces), nil, pub.Publish, nil, logp.NewLogger("http_endpoint.test"), metrics)

Check failure on line 602 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (ubuntu-latest)

use of `logp.NewLogger` forbidden because "accept a *logp.Logger as a parameter instead of creating one with logp.NewLogger" (forbidigo)

Check failure on line 602 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (windows-latest)

use of `logp.NewLogger` forbidden because "accept a *logp.Logger as a parameter instead of creating one with logp.NewLogger" (forbidigo)

Check failure on line 602 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (macos-latest)

use of `logp.NewLogger` forbidden because "accept a *logp.Logger as a parameter instead of creating one with logp.NewLogger" (forbidigo)

// Execute handler.
respRec := httptest.NewRecorder()
Expand Down Expand Up @@ -638,7 +638,7 @@

pub := new(publisher)
metrics := newInputMetrics(monitoring.NewRegistry(), logp.NewNopLogger())
h := newHandler(ctx, c, nil, pub.Publish, nil, logp.NewLogger("test"), metrics)

Check failure on line 641 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (ubuntu-latest)

use of `logp.NewLogger` forbidden because "accept a *logp.Logger as a parameter instead of creating one with logp.NewLogger" (forbidigo)

Check failure on line 641 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (windows-latest)

use of `logp.NewLogger` forbidden because "accept a *logp.Logger as a parameter instead of creating one with logp.NewLogger" (forbidigo)

Check failure on line 641 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (macos-latest)

use of `logp.NewLogger` forbidden because "accept a *logp.Logger as a parameter instead of creating one with logp.NewLogger" (forbidigo)

// Small request should be accepted.
req := httptest.NewRequest(http.MethodPost, "/", bytes.NewBufferString(`{"id":1}`))
Expand All @@ -657,7 +657,7 @@

pub := new(publisher)
metrics := newInputMetrics(monitoring.NewRegistry(), logp.NewNopLogger())
handler := newHandler(ctx, c, nil, pub.Publish, nil, logp.NewLogger("test"), metrics).(*handler)

Check failure on line 660 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (ubuntu-latest)

Error return value is not checked (errcheck)

Check failure on line 660 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (windows-latest)

Error return value is not checked (errcheck)

Check failure on line 660 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (macos-latest)

Error return value is not checked (errcheck)

// Simulate existing in-flight bytes above high water mark and
// set reject mode.
Expand All @@ -681,7 +681,7 @@

pub := new(publisher)
metrics := newInputMetrics(monitoring.NewRegistry(), logp.NewNopLogger())
handler := newHandler(ctx, c, nil, pub.Publish, nil, logp.NewLogger("test"), metrics).(*handler)

Check failure on line 684 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (ubuntu-latest)

Error return value is not checked (errcheck)

Check failure on line 684 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (windows-latest)

Error return value is not checked (errcheck)

Check failure on line 684 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (macos-latest)

Error return value is not checked (errcheck)

// Simulate having been in rejecting mode but now below low water.
handler.inFlight.Store(100)
Expand All @@ -706,7 +706,7 @@

pub := new(publisher)
metrics := newInputMetrics(monitoring.NewRegistry(), logp.NewNopLogger())
handler := newHandler(ctx, c, nil, pub.Publish, nil, logp.NewLogger("test"), metrics).(*handler)

Check failure on line 709 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (ubuntu-latest)

Error return value is not checked (errcheck)

Check failure on line 709 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (windows-latest)

Error return value is not checked (errcheck)

Check failure on line 709 in x-pack/filebeat/input/http_endpoint/handler_test.go

View workflow job for this annotation

GitHub Actions / lint (macos-latest)

Error return value is not checked (errcheck)

// Simulate being in rejecting mode at a level between low and high water.
handler.inFlight.Store(700) // Between 500 and 1000.
Expand Down
3 changes: 1 addition & 2 deletions x-pack/filebeat/input/httpjson/config_request.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ import (
"strings"
"time"

"gopkg.in/natefinch/lumberjack.v2"

"github.com/elastic/elastic-agent-libs/mapstr"
"github.com/elastic/elastic-agent-libs/transport/httpcommon"
"github.com/elastic/lumberjack"
)

type retryConfig struct {
Expand Down
Loading