Allow images from the elastic-severless-forwarder repo #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reakaleek
approved these changes
Apr 16, 2025
58 tasks
|
I think I added it becAuse all the images at the root were throwing up errors. https://github.com/elastic/elastic-serverless-forwarder/tree/main/docs Will need to double check again if it's not fixed since. |
|
I deleted the images at the root in elastic/elastic-serverless-forwarder#879. If needed, we can merge that PR first. |
Ok. It looks like I do need to merge elastic/elastic-serverless-forwarder#879 before this. Let me work on getting an approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: elastic/elastic-serverless-forwarder#879
I'm not sure why this line was added, but I was unable to get images to appear in my local versions of https://www.elastic.co/docs/reference/aws-forwarder and https://www.elastic.co/docs/reference/aws-forwarder/aws-deploy-elastic-serverless-forwarder until I removed this line.