Use substitution values in image alt and title text #1163
Conversation
colleenmcginnis
changed the title
colleenmcginnis
changed the title
| @@ -64,9 +70,10 @@ public class ImageBlock(DirectiveBlockParser parser, ParserContext context) | |||
| public override void FinalizeAndValidate(ParserContext context) | |||
| { | |||
| Label = Prop("label", "name"); | |||
| Alt = Prop("alt"); | |||
| Align = Prop("align"); | |||
| Alt = (Prop("alt") ?? "{undefined}").ReplaceSubstitutions(context); | |||
There was a problem hiding this comment.
Could you please explain what this is doing?
Will this leave a {undefined} in the alt property?
Generally, there is valid use case for an empty alt="" property. See https://www.w3.org/WAI/tutorials/images/decorative/
Not sure if this still given with this condition.
There was a problem hiding this comment.
I stole borrowed from TabSetBlock.cs 🙃 but if an empty string is better, let's do that!
There was a problem hiding this comment.
Ah interesting. I also don't understand what it's doing in TabSet :D
There was a problem hiding this comment.
@Mpdreamz does this have a specific purpose?
There was a problem hiding this comment.
Uhh I can't think of any. Must have been a leftover from frenzy coding 😸
There was a problem hiding this comment.
I'm having some trouble figuring out the right syntax. Just changing "{undefined}" to "" is the only thing I could get to work, but I don't think it makes sense to replace subs in an empty string.... Any hints? 😏
There was a problem hiding this comment.
Maybe something like:
Prop("alt")?.ReplaceSubstitutions(context) ?? "";
There was a problem hiding this comment.
Ahhh the ? after Prop("alt") was the missing piece. Thanks!
Fixes #814
This attempts to use substitution values in image
altandtitletext. I've noticed some keys being flagged as "unused" when they are only used inaltortitletext (example). I've also been building the site locally and using the HTML files in the.artifacts/assembly/directory to look for content problems (including unresolved sub keys) and there were sooo many inaltandtitletext that it was a bit difficult to track content fixes.(I hope it's ok that I picked up this issue. During spacetime I'm trying to get more familiar with how docs-builder works so I can make tiny fixes like this one as needed in the future. 🪐 )