Skip to content

Publish ECS 9.0.0 documentation #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mjwolf
Copy link

@mjwolf mjwolf commented Apr 29, 2025

Update assembler config to publish ECS v9.0.0 documentation as the current version.

@mjwolf mjwolf requested a review from a team as a code owner April 29, 2025 01:26
Copy link

Label error. Requires exactly 1 of: automation, breaking, bug, changelog:skip, chore, ci, dependencies, documentation, enhancement, feature, fix, redesign. Found:

@mjwolf
Copy link
Author

mjwolf commented Apr 29, 2025

I would like this to publish the "9.0" branch of the ecs repo, I'm not completely sure if this is the correct way to do it. If it's possible to publish tags, I can also change this to publish v9.0.0 tag, which will be more exact in publishing the correct version of ecs docs.

I also don't have permission to add a label to this PR, to make the "required-labels / check-labels" check happy here, so could someone add a label for me?

@reakaleek
Copy link
Member

Hi @mjwolf,

Thank you for your contribution! To be honest, we don't have a proper current/next strategy yet.
There could be major changes. The changes look fine to me, but I'm not entirely sure about the consequences.

Let's wait for @Mpdreamz or @bmorelli25's opinion.

@Mpdreamz
Copy link
Member

The change looks good to me and config wise I don't expect this to change.

Our current/next strategy is defined in the sense we provide the following options:

  • current & next are equal
  • current & next follow a branching model.
    • here we 'specialize' by being on the DRA and have a variable for all repositories that branch when releases are cut.
    • Other products that have their own versioning scheme or might sometimes lag behind company releases (like ECS).

What's not defined is what repositories will use what strategy.

We have a techical blocker in that we are not currently setup to publish from current branches.

We currently require links.json to be build on the main integration branches: https://github.com/elastic/docs-builder/blob/main/.github/workflows/preview-build.yml#L165-L172

Our workflow is currently only triggering on main and master. We need a Github App to be able to run more dynamically on folks different current branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants