Skip to content

Re-enable isolated build deployment write on elastic/docs-builder #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mpdreamz wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Re-enable isolated build deployment write on elastic/docs-builder #3270

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3125d9c
Allow .plan extension for assembler deploy apply --plan-file
Mpdreamz May 7, 2026
b18465d
Re-enable deployment status updates and harden fork guards in docs-pr…
Mpdreamz May 7, 2026
0cb770d
Merge branch 'main' into re-enable-isolated-build-deployments
Mpdreamz May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/docs-preview-local.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ jobs:
runs-on: ubuntu-latest
permissions:
contents: read
deployments: none
deployments: write
id-token: write
pull-requests: none
outputs:
Expand All @@ -216,10 +216,8 @@ jobs:
persist-credentials: false

- name: Create Deployment
# disabled: deployments are not enabled on this branch
if: >
false
&& env.MATCH == 'true'
env.MATCH == 'true'
&& needs.check.outputs.any_modified != 'false'
&& (
github.event_name == 'push'
Expand Down Expand Up @@ -331,6 +329,7 @@ jobs:
!cancelled()
&& needs.check.outputs.any_modified != 'false'
&& steps.internal-validate-path-prefixes.outcome == 'success'
&& (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)

- name: Upload to S3
id: s3-upload
Expand All @@ -339,6 +338,7 @@ jobs:
&& !cancelled()
&& steps.internal-docs-build.outputs.skip != 'true'
&& steps.internal-docs-build.outcome == 'success'
&& (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
env:
AWS_RETRY_MODE: standard
AWS_MAX_ATTEMPTS: 6
Expand All @@ -360,10 +360,8 @@ jobs:

- name: Update deployment status
uses: actions/github-script@v8
# disabled: deployments are not enabled on this branch
if: >
false
&& env.MATCH == 'true'
env.MATCH == 'true'
&& always()
&& steps.deployment.outputs.result
env:
Expand Down
2 changes: 1 addition & 1 deletion src/tooling/docs-builder/Commands/Assembler/DeployCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ static async (s, collector, state, ctx) => await s.Plan(collector, state.environ
/// <param name="s3BucketName">S3 bucket to deploy to.</param>
/// <param name="planFile">Path to the plan file produced by <c>assembler deploy plan</c>.</param>
[NoOptionsInjection]
public async Task<int> Apply(string environment, string s3BucketName, [Existing, ExpandUserProfile, RejectSymbolicLinks, FileExtensions(Extensions = "json")] FileInfo planFile, CancellationToken ct = default)
public async Task<int> Apply(string environment, string s3BucketName, [Existing, ExpandUserProfile, RejectSymbolicLinks, FileExtensions(Extensions = "json,plan")] FileInfo planFile, CancellationToken ct = default)
{
await using var serviceInvoker = new ServiceInvoker(collector);

Expand Down
Loading