-
Notifications
You must be signed in to change notification settings - Fork 75
Managed Elastic Agent through helm chart install updated #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know this area well so this is mostly a style review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ty for that @eedugon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. some nitpicks for the road.
I think the question of whether this works on serverless is important and should be considered if you can!
Main changes:
TOC updated to include the Helm based examples as childs of "Install on Kubernetes using Helm" section (eventually we will organize better the hierarchy of the
Install Elastic Agents in a containerized environment
element, which has too many children.Removed tech-preview banner in the 3 docs about helm based installation (the chart is currently GA based on @pkoutsovasilis shared details).
Major updates of Example: Install Fleet-managed Elastic Agent on Kubernetes using Helm
Closes elastic/ingest-docs#1531