-
Notifications
You must be signed in to change notification settings - Fork 91
Clarifications on 'no downtime' during upgrades #1421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@shainaraskas , this looks good to me, just a few comments for your review:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to address @eedugon's comments:
- linking, or being more precise about what the minimum node configuration is, is a good idea
- kibana link: we could be more precise about the kibana downtime thing, but the other upgrade doc is specific to self-managed might be misleading. Edu, in future, we could maybe use a snippet to reuse this info if you think it's helpful for the other deployment types
provided some suggestions to address this stuff
As agreed with @renshuki , we'll do some extra refinement and share with you the results before merging. |
@shainaraskas : I'm re-requesting your review here, I have adapted your changes and included all the information related with this PR (very important in my opinion (thanks @renshuki ) ) in a dedicated section of the doc. I have also updated the link to HA in ECH to the document we recently added in the other PR :) As we are planning to improve that one soon, better to link to that from this ECH upgrade doc. @renshuki : let us know how you feel it, and if it covers your original goal also. Preview here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this approach! thank you both
cc: @eedugon just in case gh won't notify you automatically
Thank you @shainaraskas and @eedugon for the great rework on this PR, I have nothing to add on my side 😄 All the points I originally mentioned are covered. |
Current wording suggests that no downtime is expected during upgrades whatever the deployment topology is.
Non-HA deployments (on single AZ) are subject to downtime as the Elasticsearch node upgrade happens inline with a rolling change.
Also for Kibana upgrade, all Kibana instances are shutdown simultaneously which makes Kibana inaccessible during the Kibana upgrade plan whatever the zone distribution is.
Preview here: