-
Notifications
You must be signed in to change notification settings - Fork 91
Specifies that agentless deployment is not supported on GovCloud #1525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -21,7 +21,7 @@ This feature currently supports agentless and agent-based deployments on Amazon | |||
* Minimum privileges vary depending on whether you need to read, write, or manage CSPM data and integrations. Refer to [CSPM privilege requirements](/solutions/security/cloud/cspm-privilege-requirements.md). | |||
* The CSPM integration is available to all {{ecloud}} users. On-premise deployments require an [Enterprise subscription](https://www.elastic.co/pricing). | |||
* CSPM only works in the `Default` {{kib}} space. Installing the CSPM integration on a different {{kib}} space will not work. | |||
* CSPM is supported only on AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. Other government cloud platforms are not supported. [Click here to request support](https://github.com/elastic/kibana/issues/new/choose). | |||
* CSPM is supported only on AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. AWS GovCloud is only supported for agent-based deployments, agentless deployments do not work on this platform. Other government cloud platforms are not supported. [Click here to request support](https://github.com/elastic/kibana/issues/new/choose). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* CSPM is supported only on AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. AWS GovCloud is only supported for agent-based deployments, agentless deployments do not work on this platform. Other government cloud platforms are not supported. [Click here to request support](https://github.com/elastic/kibana/issues/new/choose). | |
* CSPM is supported only on AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. AWS GovCloud is only supported for agent-based deployments. Agentless deployments do not work on this platform. Other government cloud platforms are not supported. [Click here to request support](https://github.com/elastic/kibana/issues/new/choose). |
I presume that you want the repetition to make the message clear, but for readability/easier text scanning, wouldn't it make sense to split it into 2 sentences? Same thing in the other file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer it as one sentence because then it's clear that by "this platform" I am referring to AWS GovCloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer it as one sentence because then it's clear that by "this platform" I am referring to AWS GovCloud.
Totally get that. What about an em dash instead since these could be two complete sentences? (Or a semicolon, though I'm not really a fan of them... 🙂)
Also, what do you think about making the link text a little clearer? (I don't think this is in Elastic's style guide, but I tend to structure sentences that have the potential to send the reader off in totally a different direction to start with information about why they might click the link followed by the link so it feels natural to read the full sentence before clicking.)
* CSPM is supported only on AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. AWS GovCloud is only supported for agent-based deployments, agentless deployments do not work on this platform. Other government cloud platforms are not supported. [Click here to request support](https://github.com/elastic/kibana/issues/new/choose). | |
* CSPM is supported only on AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. AWS GovCloud is only supported for agent-based deployments — agentless deployments do not work on this platform. Other government cloud platforms are not supported. To request support for other platforms, [open a GitHub issue](https://github.com/elastic/kibana/issues/new/choose). |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some nitpicky comments below, but they are not blocking.
@@ -21,7 +21,7 @@ This feature currently supports agentless and agent-based deployments on Amazon | |||
* Minimum privileges vary depending on whether you need to read, write, or manage CSPM data and integrations. Refer to [CSPM privilege requirements](/solutions/security/cloud/cspm-privilege-requirements.md). | |||
* The CSPM integration is available to all {{ecloud}} users. On-premise deployments require an [Enterprise subscription](https://www.elastic.co/pricing). | |||
* CSPM only works in the `Default` {{kib}} space. Installing the CSPM integration on a different {{kib}} space will not work. | |||
* CSPM is supported only on AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. Other government cloud platforms are not supported. [Click here to request support](https://github.com/elastic/kibana/issues/new/choose). | |||
* CSPM is supported only on AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. AWS GovCloud is only supported for agent-based deployments, agentless deployments do not work on this platform. Other government cloud platforms are not supported. [Click here to request support](https://github.com/elastic/kibana/issues/new/choose). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer it as one sentence because then it's clear that by "this platform" I am referring to AWS GovCloud.
Totally get that. What about an em dash instead since these could be two complete sentences? (Or a semicolon, though I'm not really a fan of them... 🙂)
Also, what do you think about making the link text a little clearer? (I don't think this is in Elastic's style guide, but I tend to structure sentences that have the potential to send the reader off in totally a different direction to start with information about why they might click the link followed by the link so it feels natural to read the full sentence before clicking.)
* CSPM is supported only on AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. AWS GovCloud is only supported for agent-based deployments, agentless deployments do not work on this platform. Other government cloud platforms are not supported. [Click here to request support](https://github.com/elastic/kibana/issues/new/choose). | |
* CSPM is supported only on AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. AWS GovCloud is only supported for agent-based deployments — agentless deployments do not work on this platform. Other government cloud platforms are not supported. To request support for other platforms, [open a GitHub issue](https://github.com/elastic/kibana/issues/new/choose). |
@@ -21,7 +21,7 @@ This page explains how to get started monitoring the security posture of your cl | |||
* Minimum privileges vary depending on whether you need to read, write, or manage CSPM data and integrations. Refer to [CSPM privilege requirements](/solutions/security/cloud/cspm-privilege-requirements.md). | |||
* The CSPM integration is available to all {{ecloud}} users. On-premise deployments require an [Enterprise subscription](https://www.elastic.co/pricing). | |||
* CSPM only works in the `Default` {{kib}} space. Installing the CSPM integration on a different {{kib}} space will not work. | |||
* CSPM is supported only on AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. Other government cloud platforms are not supported. [Click here to request support](https://github.com/elastic/kibana/issues/new/choose). | |||
* CSPM supports the AWS, GCP, and Azure commercial cloud platforms, and AWS GovCloud. AWS GovCloud is only supported for agent-based deployments, agentless deployments do not work on this platform. Other government cloud platforms are not supported. [Click here to request support](https://github.com/elastic/kibana/issues/new/choose). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the relationship between CPSM and the platforms listed? Does CPSM support the platforms or do the platforms support CPSM? I ask because this text suggests the former while the text in the other file suggests the latter.
Fixes #1524
Updates the CSPM for AWS page to reflect that agentless is not supported on AWS GovCloud.
Previews: CSPM page, CSPM for AWS page