Fix troubleshooting message URL for versions after 9.x

changelog/fragments/1759335344-fix-troubleshooting-message-url-for-versions-after-9.yaml

@@ -0,0 +1,42 @@
+# REQUIRED
+# Kind can be one of:
+# - breaking-change: a change to previously-documented behavior
+# - deprecation: functionality that is being removed in a later release
+# - bug-fix: fixes a problem in a previous version
+# - enhancement: extends functionality but does not break or fix existing behavior
+# - feature: new functionality
+# - known-issue: problems that we are aware of in a given version
+# - security: impacts on the security of a product or a user’s deployment.
+# - upgrade: important information for someone upgrading from a prior version
+# - other: does not fit into any of the other categories
+kind: bug-fix
+
+# REQUIRED for all kinds
+# Change summary; a 80ish characters long description of the change.
+summary: Fix troubleshooting docs URL for 9.x+ to prevent invalid version links
+# this field accommodate a description without length limits.
+# description:
+
+# REQUIRED for breaking-change, deprecation, known-issue
+# impact:
+
+# REQUIRED for breaking-change, deprecation, known-issue
+# action:
+
+# REQUIRED for all kinds
+# Affected component; usually one of "elastic-agent", "fleet-server", "filebeat", "metricbeat", "auditbeat", "all", etc.
+component: elastic-agent
+
+# AUTOMATED
+# OPTIONAL to manually add other PR URLs
+# PR URL: A link the PR that added the changeset.
+# If not present is automatically filled by the tooling finding the PR where this changelog fragment has been added.
+# NOTE: the tooling supports backports, so it's able to fill the original PR number instead of the backport PR number.
+# Please provide it if you are adding a fragment for a different PR.
+# pr: https://github.com/owner/repo/1234
+
+# AUTOMATED
+# OPTIONAL to manually add other issue URLs
+# Issue URL; optional; the GitHub issue related to this changeset (either closes or is part of).
+# If not present is automatically filled by the tooling with the issue linked to the PR number.
+# issue: https://github.com/owner/repo/1234

internal/pkg/agent/cmd/common.go

@@ -8,6 +8,7 @@ import (
 	"flag"
 	"fmt"
 	"os"
+	"strconv"
 	"strings"
 
 	"github.com/spf13/cobra"
@@ -23,8 +24,19 @@ import (
 
 func troubleshootMessage() string {
 	v := strings.Split(release.Version(), ".")
-	version := strings.Join(v[:2], ".")
-	return fmt.Sprintf("For help, please see our troubleshooting guide at https://www.elastic.co/guide/en/fleet/%s/fleet-troubleshooting.html", version)
+	docsURL := "https://www.elastic.co/docs/troubleshoot/ingest/fleet/common-problems"
+
+	// Use versioned docs for releases before 9.x. Fall back to unversioned docs on parse errors
+	// or when the version string is not in the expected format.
+	if len(v) >= 2 {
+		major, err := strconv.Atoi(v[0])
+		if err == nil && major < 9 {
+			ver := strings.Join(v[:2], ".")
+			docsURL = fmt.Sprintf("https://www.elastic.co/guide/en/fleet/%s/fleet-troubleshooting.html", ver)
+		}
+	}
+
+	return fmt.Sprintf("For help, please see our troubleshooting guide at %s", docsURL)
 }
 
 // NewCommand returns the default command for the agent.