-
Notifications
You must be signed in to change notification settings - Fork 204
Handle PRIVILEGE_LEVEL_CHANGE action
#10231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
internal/pkg/agent/application/actions/handlers/handle_action_privilege_level_change.go
Outdated
Show resolved
Hide resolved
internal/pkg/agent/application/actions/handlers/handle_action_privilege_level_change.go
Outdated
Show resolved
Hide resolved
…privilege_level_change.go Co-authored-by: Paolo Chilà <[email protected]>
Co-authored-by: Paolo Chilà <[email protected]>
ycombinator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michalpristas Would it be possible to add some integration/E2E tests in this PR? Failing that, could you add some manual testing steps to the PR description? Thanks.
|
added testing steps to description |
internal/pkg/agent/application/actions/handlers/handle_action_privilege_level_change.go
Outdated
Show resolved
Hide resolved
internal/pkg/agent/application/actions/handlers/handle_action_privilege_level_change.go
Outdated
Show resolved
Hide resolved
internal/pkg/agent/application/actions/handlers/handle_action_privilege_level_change.go
Show resolved
Hide resolved
Co-authored-by: Shaunak Kashyap <[email protected]>
Co-authored-by: Shaunak Kashyap <[email protected]>
…-agent into feat/switch-action
…nge.yaml Co-authored-by: Shaunak Kashyap <[email protected]>
…privilege_level_change.go Co-authored-by: Shaunak Kashyap <[email protected]>
…privilege_level_change.go Co-authored-by: Shaunak Kashyap <[email protected]>
…-agent into feat/switch-action
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
blakerouse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for working on it and iterating to get it into a good state.
to test this you need a 9.2 kibana with FF config:
This PR adds a handler for PRIVILEGE_LEVEL_CHANGE action.
Once action comes and permissions are fixed we call the code identical to
privilegeorunprivilegeCLI commands.Service manager handles user changes differently Windows being least problematic.
Systemd could do
daemon-reloadbut for consistency MacOS and Linux are handled in a same way:This is not performed if we are running using proper user
Test steps:
xpack.fleet.enableExperimental: ["enableAgentPrivilegeLevelChange"]POST kbn:api/fleet/agents/{agent_id}/privilege_level_changeFixes: #4973