-
Notifications
You must be signed in to change notification settings - Fork 204
[AutoOps] Provide Sample Configuration to Debug Data #10268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This provides a separate OTel configuration to allow users to better understand what data they are shipping with the AutoOps ES module.
💛 Build succeeded, but was flaky
Failed CI Stepscc @pickypg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as these new pipelines with the debug exporters are identical to their otlphttp exporter counterparts except, of course, for the exporter used, I wonder if you could consolidate these into one set of pipelines that defined both exporters and used a routingconnector based on an environment variable to route the data to one or the other exporter?
That would save a lot of duplication and the need for ensuring that the two sets of pipelines are kept in sync whenever one changes.
I see |
I'm not familiar with how the If we decide to go with two sets of nearly-identical configuration files, we might want to consider introducing a |
I like this. I have been actively thinking about how to provide a set of configuration that enables providing TLS / SSL configuration without being a total duplication. If I had different ways to piece together the receivers, I could have the exporters and pipeline provided by a different file, then allow the "user" to merge them together as needed (even better with #10267). |
I'm far from an OTel configuration expert and I'm starting to think there's probably already mechanisms or tricks to merge OTel configuration files defining different components and/or ideas for generating configuration from templates that someone has already come up with. So I'd really like to hear from folks like @andrzej-stencel and @swiatekm who are active in the OTel community before we head down any concrete paths. |
|
Happy to hear their insights, but unfortuantely I don't think "merging" really works in any functional way yet without
I tried locally with the latest Elastic Agent to use
|
|
The Routing connector approach will surely have a performance penalty. Whether it's big or small or negligible would need to be tested. I think however that using the Routing connector in this case will harm configuration readability and comprehensibility, which is the opposite that we seem to want here - the example configurations for debugging should be simple, to enhance user understanding. I'm in favor of generating the similar configurations from a template, as mentioned above. |
andrzej-stencel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good as it is now. Would be good to prevent duplication by e.g. templating.
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
ycombinator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now. Would be good to reduce duplication via templating as discussed in this PR but that can be done via a follow up PR.
This provides a separate OTel configuration to allow users to better understand what data they are shipping with the AutoOps ES module. (cherry picked from commit 8f1cc86)
This provides a separate OTel configuration to allow users to better understand what data they are shipping with the AutoOps ES module. (cherry picked from commit 8f1cc86) Co-authored-by: Chris Earle <[email protected]>
This provides a separate OTel configuration to allow users to better understand what data they are shipping with the AutoOps ES module.
What does this PR do?
This adds a new OTel configuration available for every OS that helps users to understand what data the AutoOps ES module exports.
Why is it important?
Many users have asked what data is collected by AutoOps and this helps them to explore it locally before shipping it anywhree.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
None. This adds a new, optional configuration that the user can run to better understand AutoOps.
How to test this PR locally
Run the Elastic Agent against an Elasticsearch cluster.
You will want to supply these environment variables (with values filled in relevant to your environment):