Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 2, 2025

This uses the expected :: syntax instead of . for the --set argument.

What does this PR do?

Fixes the example text for showing users how to use the --set argument.

Why is it important?

The documentation shows the correct format.


This is an automatic backport of pull request #10259 done by [Mergify](https://mergify.com).

This uses the expected `::` syntax instead of `.` for the `--set`
argument.

(cherry picked from commit e917e0a)
@mergify mergify bot requested a review from a team as a code owner October 2, 2025 13:18
@mergify mergify bot added the backport label Oct 2, 2025
@mergify mergify bot requested review from michalpristas and swiatekm and removed request for a team October 2, 2025 13:18
@mergify mergify bot assigned pickypg Oct 2, 2025
@github-actions github-actions bot added bug Something isn't working skip-changelog labels Oct 2, 2025
pickypg
pickypg previously approved these changes Oct 2, 2025
@pickypg pickypg enabled auto-merge (squash) October 2, 2025 13:21
@mergify
Copy link
Contributor Author

mergify bot commented Oct 6, 2025

This pull request has not been merged yet. Could you please review and merge it @pickypg? 🙏

@pickypg pickypg disabled auto-merge October 6, 2025 16:03
@pickypg
Copy link
Member

pickypg commented Oct 6, 2025

Closing this out for 9.0. The validation was different, so the tests properly don't pass. Changing them would be a breaking change, which is not intended for a bug fix.

@pickypg pickypg closed this Oct 6, 2025
@pickypg pickypg deleted the mergify/bp/9.0/pr-10259 branch October 6, 2025 16:03
@pickypg pickypg restored the mergify/bp/9.0/pr-10259 branch October 6, 2025 16:04
@pickypg
Copy link
Member

pickypg commented Oct 6, 2025

Actually, on second thought, the tests are a secondary part of this PR. I'm going to not apply the tests and, instead, only apply the CLI change.

@pickypg pickypg reopened this Oct 6, 2025
@pickypg pickypg enabled auto-merge (squash) October 6, 2025 16:15
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

cc @pickypg

@pickypg pickypg merged commit 5728ad6 into 9.0 Oct 6, 2025
21 checks passed
@pickypg pickypg deleted the mergify/bp/9.0/pr-10259 branch October 6, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bug Something isn't working skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants