-
Notifications
You must be signed in to change notification settings - Fork 204
[9.1] (backport #10153) Rewrite the beats receiver log test using common tooling #10507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Cherry-pick of 71ece0d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
This pull request has not been merged yet. Could you please review and merge it @swiatekm? 🙏 |
|
@swiatekm CI failed on this backport - can you take a look? |
|
Looks like this test wasn't originally ported to this branch, which seems like an oversight. I'll see if there's any obstruction to doing so. |
|
There's currently some changes missing in 9.1 whose lack makes this test flaky, so I'll skip backporting it. |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
dfb481d to
8881b8a
Compare
|
This pull request has not been merged yet. Could you please review and merge it @swiatekm? 🙏 |
8881b8a to
f4f6063
Compare
|
Looks like the windows tests are failing because Vihas' fix for retrying npipes in beats is not yet in this branch. And it looks like #10849 needs to go in first. |
f4f6063 to
235e442
Compare
💚 Build Succeeded
History
cc @swiatekm |
What does this PR do?
Re-enables the integration test for comparing logs between beats processes and beats receivers and rewrites it to use normal integration test tooling, making it simpler and more observable:
elastic-agent logsinstead of capturing agent output directly.Why is it important?
This test should be enabled and reliable.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog toolRelated issues
This is an automatic backport of pull request #10153 done by [Mergify](https://mergify.com).