Skip to content

Conversation

@belimawr
Copy link
Contributor

What does this PR do?

Use unique index for TestOtelLogsIngestion

Why is it important?

TestOtelLogsIngestion was flaky and could cause other tests to become flaky due to mapping conflicts, using a unique index fixes the problem.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

## Disruptive User Impact

How to test this PR locally

Start a Elastic Stack and export the following env vars:

ELASTICSEARCH_HOST
ELASTICSEARCH_USERNAME
ELASTICSEARCH_PASSWORD
KIBANA_HOST
KIBANA_USERNAME
KIBANA_PASSWORD

Package and run the tests:

# Package Elastic Agent, adjust according to your OS
DEV=true SNAPSHOT=true EXTERNAL=true PACKAGES="tar.gz" PLATFORMS=linux/amd64 mage -v package

# Run the tests, adjust according to your OS
DEV=true SNAPSHOT=true EXTERNAL=true PACKAGES="tar.gz" PLATFORMS=linux/amd64 AGENT_VERSION="9.3.0-SNAPSHOT" mage -v integration:local TestOtelLogsIngestion

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@belimawr belimawr requested a review from a team as a code owner November 19, 2025 13:54
@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2025

This pull request does not have a backport label. Could you fix it @belimawr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@belimawr
Copy link
Contributor Author

The failing test is not related to this PR, there is already an issue for it: #5437

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Nov 20, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@belimawr belimawr requested a review from swiatekm November 20, 2025 14:44
swiatekm
swiatekm previously approved these changes Nov 20, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-TestOtelLogsIngestion upstream/fix-TestOtelLogsIngestion
git merge upstream/main
git push upstream fix-TestOtelLogsIngestion

@belimawr
Copy link
Contributor Author

@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

cc @belimawr

@belimawr
Copy link
Contributor Author

I created a issue for the BK failure: elastic/beats#47767

@belimawr belimawr requested a review from swiatekm November 25, 2025 13:18
@belimawr belimawr merged commit 85241ff into elastic:main Nov 25, 2025
21 checks passed
@belimawr belimawr added the backport-active-all Automated backport with mergify to all the active branches label Nov 25, 2025
@github-actions
Copy link
Contributor

@Mergifyio backport 8.19 9.1 9.2

@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2025

backport 8.19 9.1 9.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 25, 2025
mergify bot pushed a commit that referenced this pull request Nov 25, 2025
mergify bot pushed a commit that referenced this pull request Nov 25, 2025
(cherry picked from commit 85241ff)

# Conflicts:
#	magefile.go
belimawr added a commit that referenced this pull request Nov 25, 2025
(cherry picked from commit 85241ff)

Co-authored-by: Tiago Queiroz <[email protected]>
belimawr added a commit that referenced this pull request Dec 3, 2025
(cherry picked from commit 85241ff)

Co-authored-by: Tiago Queiroz <[email protected]>
swiatekm pushed a commit that referenced this pull request Dec 5, 2025
(cherry picked from commit 85241ff)

# Conflicts:
#	magefile.go
belimawr added a commit that referenced this pull request Dec 5, 2025
…11420)

(cherry picked from commit 85241ff)

# Conflicts:
#	magefile.go


(cherry picked from commit 85241ff)

# Conflicts:
#	magefile.go

---------

Co-authored-by: Tiago Queiroz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Flaky Test]: TestOtelLogsIngestion – Expected 10000 logs, got &{0}

4 participants