Skip to content

Conversation

@straistaru
Copy link
Contributor

@straistaru straistaru commented Nov 20, 2025

What does this PR do?

This PR does two things:

  • Passes the commit info to the "Publish to serverless" pipeline.
  • Tags internal internal release images per arch using a suffix (-amd64 or -arm64)

Why is it important?

The “Publish to serverless” pipeline currently builds off HEAD, which may differ from the commit for which it was triggered. Supplying the commit SHA ensures the promoted build matches what was verified.

Additionally, tagging images per architecture prevents a later single-arch rebuild of the same commit from temporarily overwriting the previously published multi-arch image. Without separate tags, users could pull an architecture that doesn’t match their host while the pipeline is still running.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

N/A

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

This pull request does not have a backport label. Could you fix it @straistaru? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@straistaru straistaru changed the title Pass branch and commit info to the Publish to serverless pipeline Pin serverless publish commit and add arch-specific image tags Nov 21, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @straistaru

@straistaru straistaru requested a review from a team November 21, 2025 15:07
@straistaru straistaru marked this pull request as ready for review November 21, 2025 15:11
@straistaru straistaru requested review from a team as code owners November 21, 2025 15:11
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the change looks reasonable. manifest should contain updated sources

@straistaru
Copy link
Contributor Author

Result of the test:
Screenshot 2025-11-21 at 17 59 24

docker manifest inspect docker.elastic.co/observability-ci/ecp-elastic-agent-service:git-31e360145ec5
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 4924,
         "digest": "sha256:f5f8c8643c88088973bc5993ee54c258e942878ec417740d455f57b0e5b5dd90",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 4924,
         "digest": "sha256:13e62b42c1b74d08528f19571babd345deb47dae8ee9b40014f021bd37afd399",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      }
   ]
}

@straistaru straistaru enabled auto-merge (squash) November 24, 2025 11:31
@straistaru straistaru merged commit c5a4d1a into elastic:main Nov 24, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants