-
Notifications
You must be signed in to change notification settings - Fork 204
Pin serverless publish commit and add arch-specific image tags #11299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request does not have a backport label. Could you fix it @straistaru? 🙏
|
5f9278a to
31e3601
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @straistaru |
michalpristas
approved these changes
Nov 21, 2025
Contributor
michalpristas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the change looks reasonable. manifest should contain updated sources
Contributor
Author
|
v1v
reviewed
Nov 21, 2025
v1v
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

What does this PR do?
This PR does two things:
-amd64or-arm64)Why is it important?
The “Publish to serverless” pipeline currently builds off HEAD, which may differ from the commit for which it was triggered. Supplying the commit SHA ensures the promoted build matches what was verified.
Additionally, tagging images per architecture prevents a later single-arch rebuild of the same commit from temporarily overwriting the previously published multi-arch image. Without separate tags, users could pull an architecture that doesn’t match their host while the pipeline is still running.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
N/A
How to test this PR locally
Related issues
Questions to ask yourself