-
Notifications
You must be signed in to change notification settings - Fork 204
Add cloud-defend to agent container images #11450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 7 commits
5495670
c821fdc
ff3816b
ed3f208
9d27337
9b1e075
c012add
62f2e1b
e77ca83
78d9508
f702518
c9eb0f3
2b79b9e
8b4e0c6
ff6ff94
1df3b9d
77a713f
ab822c1
a07cca9
257357d
5f9c2c3
a3c2437
59cca00
d02020a
9354b42
7b3c377
efd7d9b
110d8c0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # REQUIRED | ||
| # Kind can be one of: | ||
| # - breaking-change: a change to previously-documented behavior | ||
| # - deprecation: functionality that is being removed in a later release | ||
| # - bug-fix: fixes a problem in a previous version | ||
| # - enhancement: extends functionality but does not break or fix existing behavior | ||
| # - feature: new functionality | ||
| # - known-issue: problems that we are aware of in a given version | ||
| # - security: impacts on the security of a product or a user’s deployment. | ||
| # - upgrade: important information for someone upgrading from a prior version | ||
| # - other: does not fit into any of the other categories | ||
| kind: enhancement | ||
|
|
||
| # REQUIRED for all kinds | ||
| # Change summary; a 80ish characters long description of the change. | ||
| summary: Add cloud-defend to container image agent packages | ||
|
|
||
| # REQUIRED for breaking-change, deprecation, known-issue | ||
| # Long description; in case the summary is not enough to describe the change | ||
| # this field accommodate a description without length limits. | ||
| # description: | ||
|
|
||
| # REQUIRED for breaking-change, deprecation, known-issue | ||
| # impact: | ||
|
|
||
| # REQUIRED for breaking-change, deprecation, known-issue | ||
| # action: | ||
|
|
||
| # REQUIRED for all kinds | ||
| # Affected component; usually one of "elastic-agent", "fleet-server", "filebeat", "metricbeat", "auditbeat", "all", etc. | ||
| component: elastic-agent | ||
|
|
||
| # AUTOMATED | ||
| # OPTIONAL to manually add other PR URLs | ||
| # PR URL: A link the PR that added the changeset. | ||
| # If not present is automatically filled by the tooling finding the PR where this changelog fragment has been added. | ||
| # NOTE: the tooling supports backports, so it's able to fill the original PR number instead of the backport PR number. | ||
| # Please provide it if you are adding a fragment for a different PR. | ||
| # pr: https://github.com/owner/repo/1234 | ||
|
|
||
| # AUTOMATED | ||
| # OPTIONAL to manually add other issue URLs | ||
| # Issue URL; optional; the GitHub issue related to this changeset (either closes or is part of). | ||
| # If not present is automatically filled by the tooling with the issue linked to the PR number. | ||
| # issue: https://github.com/owner/repo/1234 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -95,6 +95,16 @@ components: | |
| - *linux-amd64 | ||
| - *linux-arm64 | ||
| packageTypes: *all-package-types | ||
| - &comp-cloud-defend | ||
| projectName: cloud-defend | ||
| packageName: cloud-defend-{{.Version}}-{{.Platform}}.{{.Ext}} | ||
| rootDir: cloud-defend-{{.Version}}-{{.Platform}} | ||
| binaryName: cloud-defend | ||
| fips: false | ||
| platforms: | ||
| - *linux-amd64 | ||
| packageTypes: | ||
| - *pkg-type-docker | ||
| - &comp-connectors | ||
| projectName: connectors | ||
| packageName: connectors-{{.Version}}.zip | ||
|
|
@@ -241,6 +251,20 @@ shared: | |
|
|
||
| # components included in elastic-agent package specs defined before components support in this YAML | ||
| - &elastic_agent_components | ||
| components: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you might need a docker specific components list to prevent cloud-defend from being packaged into the native .tar.gz build artifact
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It turns out this is caused by a problem in the mage packaging scripts. They were skipping the download of components which didn't apply to the package type, but not skipping the actual packaging of them. I've updated the magefile to skip both steps now. cloud-defend is the first component not use
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When using |
||
| - *comp-agentbeat | ||
| - *comp-apm_server | ||
| - *comp-cloudbeat | ||
| - *comp-cloud-defend | ||
| - *comp-connectors | ||
| - *comp-endpoint | ||
| - *comp-fleet-server | ||
| - *comp-pf-elastic-collector | ||
| - *comp-pf-elastic-symbolizer | ||
| - *comp-pf-host-agent | ||
|
|
||
| # components for cloud/service variants (excludes cloud-defend) | ||
| - &elastic_agent_cloud_components | ||
| components: | ||
| - *comp-agentbeat | ||
| - *comp-apm_server | ||
|
|
@@ -436,6 +460,14 @@ shared: | |
| <<: *linux_otel_files | ||
| <<: *agent_unpacked_components_files | ||
|
|
||
| - &agent_cloud_binary_spec | ||
| <<: *common | ||
| <<: *elastic_agent_cloud_components | ||
| files: | ||
| <<: *agent_binary_files | ||
| <<: *linux_otel_files | ||
| <<: *agent_unpacked_components_files | ||
|
|
||
| - &agent_binary_fips_spec | ||
| <<: *common_fips | ||
| <<: *elastic_agent_fips_components | ||
|
|
@@ -538,6 +570,31 @@ shared: | |
| source: '{{ repo.RootDir }}/deploy/kubernetes/elastic-agent-standalone/templates.d' | ||
| mode: 0755 | ||
|
|
||
| - &agent_cloud_docker_spec | ||
| <<: *agent_cloud_binary_spec | ||
| extra_vars: | ||
| dockerfile: 'Dockerfile.elastic-agent.tmpl' | ||
| docker_entrypoint: 'docker-entrypoint.elastic-agent.tmpl' | ||
| user: '{{ .BeatName }}' | ||
| linux_capabilities: '' | ||
| beats_install_path: "install" | ||
| files: | ||
| 'elastic-agent.yml': | ||
| source: 'elastic-agent.docker.yml' | ||
| mode: 0600 | ||
| config: true | ||
| 'otel.yml': | ||
| source: 'otel.yml' | ||
| mode: 0600 | ||
| config: true | ||
| '.elastic-agent.active.commit': | ||
| content: > | ||
| {{ commit }} | ||
| mode: 0644 | ||
| 'hints.inputs.d': | ||
| source: '{{ repo.RootDir }}/deploy/kubernetes/elastic-agent-standalone/templates.d' | ||
| mode: 0755 | ||
|
|
||
| - &agent_docker_fips_spec | ||
| <<: *agent_binary_fips_spec | ||
| extra_vars: | ||
|
|
@@ -1458,7 +1515,7 @@ specs: | |
| arch: amd64 | ||
| types: [docker] | ||
| spec: | ||
| <<: *agent_docker_spec | ||
| <<: *agent_cloud_docker_spec | ||
| # The cloud image is always based on Wolfi | ||
| <<: *docker_wolfi_spec | ||
| <<: *docker_builder_spec | ||
|
|
@@ -1471,7 +1528,7 @@ specs: | |
| arch: arm64 | ||
| types: [docker] | ||
| spec: | ||
| <<: *agent_docker_spec | ||
| <<: *agent_cloud_docker_spec | ||
| # The cloud image is always based on Wolfi | ||
| <<: *docker_wolfi_arm_spec | ||
| <<: *docker_builder_arm_spec | ||
|
|
@@ -1485,7 +1542,7 @@ specs: | |
| arch: amd64 | ||
| types: [ docker ] | ||
| spec: | ||
| <<: *agent_docker_spec | ||
| <<: *agent_cloud_docker_spec | ||
| # The service image is always based on Wolfi | ||
| <<: *docker_wolfi_spec | ||
| <<: *docker_builder_spec | ||
|
|
@@ -1499,7 +1556,7 @@ specs: | |
| arch: arm64 | ||
| types: [ docker ] | ||
| spec: | ||
| <<: *agent_docker_spec | ||
| <<: *agent_cloud_docker_spec | ||
| # The service image is always based on Wolfi | ||
| <<: *docker_wolfi_arm_spec | ||
| <<: *docker_builder_arm_spec | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.