[8.16](backport #5853) [helm]: integration config for scheduler and controller-manager conditions and containers logs #5882
+15
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
kaanyalti and
pchila
and removed request for
a team
|
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
|
@pkoutsovasilis should we wait for 8.16.0 to be released or should we merge this one right now? |
Contributor
Being completely transparent here, I am not sure 😄 My logic is that this change is not a breaking one, the helm chart is not yet released so I don't see any immediate reason to wait for 8.16.0 release. But please do correct me if I miss anything 🙂 |
pkoutsovasilis
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I was testing k8s standalone elastic-agent using the plain k8s manifest under
deploy/kubernetes/elastic-agent-standalone-kubernetes.yamlbut I also tried to get the same results with the elastic-agent helm chart and I tried to replicate the produced data with the elastic-agent helm chart. This effort uncovered some yaml format issues and some inconsistencies for container logs which this PR handlesWhy is it important?
Because it fixes bugs 🙂
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
N/A
How to test this PR locally
Related issues
-
This is an automatic backport of pull request #5853 done by Mergify.