-
Notifications
You must be signed in to change notification settings - Fork 175
[8.x](backport #6662) [CI] Fix throttled windows test failures #6694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8d16650
[CI] Fix throttled windows test failures (#6662)
pazone 885885a
Merged
pazone 33e411a
Merge branch '8.x' into mergify/bp/8.x/pr-6662
pazone 6d2e04f
Resolved conflicts
pazone 8520f59
Merge branch 'mergify/bp/8.x/pr-6662' of github.com:elastic/elastic-a…
pazone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,11 @@ echo "~~~ Agent version: $env:AGENT_VERSION" | |
$env:SNAPSHOT = $true | ||
|
||
echo "~~~ Building test binaries" | ||
mage build:testBinaries | ||
& mage build:testBinaries | ||
if ($LASTEXITCODE -ne 0) { | ||
Write-Error "Failed to build test binaries" | ||
exit 1 | ||
} | ||
$osInfo = (Get-CimInstance Win32_OperatingSystem).Caption + " " + (Get-CimInstance Win32_OperatingSystem).OSArchitecture -replace " ", "_" | ||
$root_suffix="" | ||
if ($TEST_SUDO -eq "true") { | ||
|
@@ -34,10 +38,12 @@ if ($TEST_SUDO -eq "true") { | |
$fully_qualified_group_name="${GROUP_NAME}${root_suffix}_${osInfo}" | ||
$outputXML = "build/${fully_qualified_group_name}.integration.xml" | ||
$outputJSON = "build/${fully_qualified_group_name}.integration.out.json" | ||
$TestsExitCode = 0 | ||
try { | ||
Get-Ess-Stack -StackVersion $PACKAGE_VERSION | ||
Write-Output "~~~ Running integration test group: $GROUP_NAME as user: $env:USERNAME" | ||
gotestsum --no-color -f standard-quiet --junitfile "${outputXML}" --jsonfile "${outputJSON}" -- -tags=integration -shuffle=on -timeout=2h0m0s "github.com/elastic/elastic-agent/testing/integration" -v -args "-integration.groups=$GROUP_NAME" "-integration.sudo=$TEST_SUDO" | ||
& gotestsum --no-color -f standard-quiet --junitfile "${outputXML}" --jsonfile "${outputJSON}" -- -tags=integration -shuffle=on -timeout=2h0m0s "github.com/elastic/elastic-agent/testing/integration" -v -args "-integration.groups=$GROUP_NAME" "-integration.sudo=$TEST_SUDO" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is & actually needed here? My understanding is that & is needed to run a command stored in a variable, so direct execution would work. |
||
$TestsExitCode = $LASTEXITCODE | ||
} finally { | ||
ess_down | ||
|
||
|
@@ -49,3 +55,7 @@ try { | |
Write-Output "Cannot generate HTML test report: $outputXML not found" | ||
} | ||
} | ||
|
||
if ($TestsExitCode -ne 0) { | ||
exit 1 | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
&
actually needed here? My understanding is that&
is needed to run a command stored in a variable, so a direct execution would work.