-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.18](backport #6662) [CI] Fix throttled windows test failures #6696
base: 8.18
Are you sure you want to change the base?
Conversation
* CI: Fifx throttled windows test failures * Use LASTEXITCODE to catch test failures * Update .buildkite/scripts/integration-tests.ps1 Co-authored-by: Doug W <[email protected]> * Added check to buildTestBinaries * Apply suggestions from code review Co-authored-by: Doug W <[email protected]> --------- Co-authored-by: Doug W <[email protected]> Co-authored-by: Julien Lind <[email protected]> (cherry picked from commit 87360e6) # Conflicts: # .buildkite/scripts/integration-tests.ps1
Cherry-pick of 87360e6 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request has not been merged yet. Could you please review and merge it @pazone? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pazone needs conflicts resolution
@pazone please don't forget to have a look here |
This pull request has not been merged yet. Could you please review and merge it @pazone? 🙏 |
cc @cachedout |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM same comment as in #6694 (review)
What does this PR do?
In some cases windows tests failures were throttled and the step was false-passing
Why is it important?
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself
This is an automatic backport of pull request #6662 done by [Mergify](https://mergify.com).