-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Remove instances configurations from the integration test stack #6719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
cmacknz
approved these changes
Feb 10, 2025
|
kuisathaverat
approved these changes
Feb 11, 2025
oakrizan
approved these changes
Feb 13, 2025
Merged
8 tasks
Merged
8 tasks
Merged
8 tasks
pazone
added a commit
that referenced
this pull request
Feb 13, 2025
…6719) (#6848) * CI: Remove instances configurations from the test stack * Added test_infra to extended pipeline trigger (cherry picked from commit 387970d) Co-authored-by: Pavel Zorin <[email protected]>
pazone
added a commit
that referenced
this pull request
Feb 13, 2025
…6719) (#6844) * CI: Remove instances configurations from the test stack * Added test_infra to extended pipeline trigger (cherry picked from commit 387970d) Co-authored-by: Pavel Zorin <[email protected]>
pazone
added a commit
that referenced
this pull request
Feb 14, 2025
…6719) (#6845) * CI: Remove instances configurations from the test stack * Added test_infra to extended pipeline trigger (cherry picked from commit 387970d) Co-authored-by: Pavel Zorin <[email protected]>
pazone
added a commit
that referenced
this pull request
Feb 20, 2025
…6719) (#6846) * CI: Remove instances configurations from the test stack * Added test_infra to extended pipeline trigger (cherry picked from commit 387970d) Co-authored-by: Pavel Zorin <[email protected]> Co-authored-by: Dimitrios Liappis <[email protected]>
pazone
added a commit
that referenced
this pull request
Feb 20, 2025
…6719) (#6847) * CI: Remove instances configurations from the test stack * Added test_infra to extended pipeline trigger (cherry picked from commit 387970d) Co-authored-by: Pavel Zorin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-active-all
Automated backport with mergify to all the active branches
enhancement
New feature or request
skip-changelog
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Team:Ingest-EngProd
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
instance_configuration_id
as @kuisathaverat suggested here.Why is it important?
Instance types are selected by the
deployment_template_id
selected; the values of the instance types can change when thedeployment_template_id
. The use of fixed values could cause issues in deployments. Those instance types can be deleted, inappropriate for the stack version, expensive, consume more resources than needed, etc. We must use the instance types the Platform team selects for eachdeployment_template_id
, they are the instance types tested in ECH.Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself