Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove instances configurations from the integration test stack #6719

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Feb 5, 2025

What does this PR do?

Removes instance_configuration_id as @kuisathaverat suggested here.

Why is it important?

Instance types are selected by the deployment_template_id selected; the values of the instance types can change when the deployment_template_id. The use of fixed values could cause issues in deployments. Those instance types can be deleted, inappropriate for the stack version, expensive, consume more resources than needed, etc. We must use the instance types the Platform team selects for each deployment_template_id, they are the instance types tested in ECH.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pazone pazone added enhancement New feature or request skip-changelog Team:Ingest-EngProd backport-active-all Automated backport with mergify to all the active branches labels Feb 5, 2025
@pazone pazone requested a review from a team as a code owner February 5, 2025 17:26
@mergify mergify bot assigned pazone Feb 5, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 5, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pazone pazone requested a review from a team as a code owner February 5, 2025 19:02
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pazone pazone merged commit 387970d into main Feb 13, 2025
15 checks passed
@pazone pazone deleted the ci_int_test_stack_rm_instance_conf branch February 13, 2025 11:00
mergify bot pushed a commit that referenced this pull request Feb 13, 2025
…6719)

* CI: Remove instances configurations from the test stack

* Added test_infra to extended pipeline trigger

(cherry picked from commit 387970d)
mergify bot pushed a commit that referenced this pull request Feb 13, 2025
…6719)

* CI: Remove instances configurations from the test stack

* Added test_infra to extended pipeline trigger

(cherry picked from commit 387970d)
mergify bot pushed a commit that referenced this pull request Feb 13, 2025
…6719)

* CI: Remove instances configurations from the test stack

* Added test_infra to extended pipeline trigger

(cherry picked from commit 387970d)
mergify bot pushed a commit that referenced this pull request Feb 13, 2025
…6719)

* CI: Remove instances configurations from the test stack

* Added test_infra to extended pipeline trigger

(cherry picked from commit 387970d)
mergify bot pushed a commit that referenced this pull request Feb 13, 2025
…6719)

* CI: Remove instances configurations from the test stack

* Added test_infra to extended pipeline trigger

(cherry picked from commit 387970d)
pazone added a commit that referenced this pull request Feb 13, 2025
…6719) (#6848)

* CI: Remove instances configurations from the test stack

* Added test_infra to extended pipeline trigger

(cherry picked from commit 387970d)

Co-authored-by: Pavel Zorin <[email protected]>
pazone added a commit that referenced this pull request Feb 13, 2025
…6719) (#6844)

* CI: Remove instances configurations from the test stack

* Added test_infra to extended pipeline trigger

(cherry picked from commit 387970d)

Co-authored-by: Pavel Zorin <[email protected]>
pazone added a commit that referenced this pull request Feb 14, 2025
…6719) (#6845)

* CI: Remove instances configurations from the test stack

* Added test_infra to extended pipeline trigger

(cherry picked from commit 387970d)

Co-authored-by: Pavel Zorin <[email protected]>
pazone added a commit that referenced this pull request Feb 20, 2025
…6719) (#6846)

* CI: Remove instances configurations from the test stack

* Added test_infra to extended pipeline trigger

(cherry picked from commit 387970d)

Co-authored-by: Pavel Zorin <[email protected]>
Co-authored-by: Dimitrios Liappis <[email protected]>
pazone added a commit that referenced this pull request Feb 20, 2025
…6719) (#6847)

* CI: Remove instances configurations from the test stack

* Added test_infra to extended pipeline trigger

(cherry picked from commit 387970d)

Co-authored-by: Pavel Zorin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-all Automated backport with mergify to all the active branches enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Ingest-EngProd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants