Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otel: adjust TestFBOtelRestartE2E to validate that deduplication works #6819

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

otel: adjust TestFBOtelRestartE2E to validate that deduplication works #6819

wants to merge 1 commit into from

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented Feb 11, 2025 •
edited
Loading

What does this PR do?

This commit updates the TestFBOtelRestartE2E to enable the logs_dynamic_id option in the elasticsearchexporter. When enabled it allows deduplication of ingested logs in the same way that the beats elasticsearch output does today.

See https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-deduplication.html

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Feb 11, 2025
@mauri870 mauri870 self-assigned this Feb 11, 2025
@mauri870 mauri870 requested a review from a team as a code owner February 11, 2025 16:56
@mauri870 mauri870 requested review from swiatekm and pchila February 11, 2025 16:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870 mauri870 changed the title otel: adjust TestFBOtelRestartE2E to validate deduplication works otel: adjust TestFBOtelRestartE2E to validate that deduplication works Feb 11, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 11, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mauri870 mauri870 force-pushed the otel-restart-test-duplicates branch from adc2425 to d8d9cb2 Compare February 11, 2025 17:07
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@mauri870 mauri870

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mauri870 @elasticmachine @swiatekm @pierrehilbert