Skip to content

[FIPS][Integration Test] Ensure FIPS-capable Agent can connect to FIPS-capable Fleet Server in an ECH FRH environment #8046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 21, 2025

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Apr 30, 2025

What does this PR do?

This PR adds an integration test that ensures that a FIPS-capable Elastic Agent running in an ECH FRH (FedRamp High) environment is able to successfully connect to its own local Fleet Server instance (which, by definition should also be FIPS-capable and running in the ECH FRH environment).

Why is it important?

To ensure that FIPS-capable Agent is able to connect to a FIPS-capable Fleet Server in an ECH FRH environment.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Copy link
Contributor

mergify bot commented Apr 30, 2025

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@ycombinator ycombinator added skip-changelog backport-8.19 Automated backport to the 8.19 branch labels Apr 30, 2025
@ycombinator ycombinator force-pushed the fips-it-agent-fleet-tls-ech branch from 1753a7a to 9f54dfe Compare May 9, 2025 20:26
@ycombinator ycombinator marked this pull request as ready for review May 9, 2025 23:28
@ycombinator ycombinator requested a review from a team as a code owner May 9, 2025 23:28
@ycombinator ycombinator requested review from a team as code owners May 10, 2025 00:11
@ycombinator ycombinator force-pushed the fips-it-agent-fleet-tls-ech branch 2 times, most recently from e10e3c1 to e4a60cb Compare May 13, 2025 11:40
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label May 14, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

v1v
v1v previously approved these changes May 14, 2025
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed just the CI changes, LGTM

Copy link
Contributor

mergify bot commented May 19, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fips-it-agent-fleet-tls-ech upstream/fips-it-agent-fleet-tls-ech
git merge upstream/main
git push upstream fips-it-agent-fleet-tls-ech

@elasticmachine
Copy link
Contributor

elasticmachine commented May 20, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @ycombinator

Copy link

@ycombinator ycombinator requested a review from v1v May 20, 2025 11:02
@ycombinator ycombinator merged commit 83ece2c into elastic:main May 21, 2025
10 of 13 checks passed
@ycombinator ycombinator deleted the fips-it-agent-fleet-tls-ech branch May 21, 2025 16:10
mergify bot pushed a commit that referenced this pull request May 21, 2025
…S-capable Fleet Server in an ECH FRH environment (#8046)

* WIP: scaffolding for test

* WIP: Print out env vars

* Update comment

* Running mage fmt

* Fix syntax errors

* Update comments

* Flesh out test

* Reference PR from elastic-agent-libs

* Removing comment

* Remove comment that is no longer necessary

* Export INTEGRATIONS_SERVER_HOST from ESS deployment's terraform output

* Set up INTEGRATIONS_SERVER_HOST environment variable

* Fixing API errors

* Bump elastic-agent-libs

(cherry picked from commit 83ece2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants