Skip to content

Update OTel components to v1.31.0/v0.125.0 #8055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented May 1, 2025

What does this PR do?

Updates the OTel components to v1.31.0/v0.125.0.

This update was performed using following command:

.ci/scripts/otel-update.sh v0.125.0 v1.31.0 v0.125.0 

It also updates github.com/elastic/opentelemetry-collector-components/connector/elasticapmconnector to v0.3.0 to take care of API conflicts amongst dependencies of different versions.

Why is it important?

To keep OTel dependencies up-to-date.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • [] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

How to test this PR locally

go build .
sudo ./elastic-agent otel

@ycombinator ycombinator requested a review from a team as a code owner May 1, 2025 15:13
@ycombinator ycombinator requested review from kaanyalti and pchila May 1, 2025 15:13
Copy link
Contributor

mergify bot commented May 1, 2025

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@ycombinator ycombinator added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-active-all Automated backport with mergify to all the active branches labels May 1, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@ycombinator
Copy link
Contributor Author

Some other dependencies need updating first:

$ go build .
# github.com/elastic/elastic-agent-autodiscover/docker
../../../.gvm/pkgsets/go1.24.2/global/pkg/mod/github.com/elastic/[email protected]/docker/watcher.go:117:44: undefined: types.EventsOptions
../../../.gvm/pkgsets/go1.24.2/global/pkg/mod/github.com/elastic/[email protected]/docker/watcher.go:269:20: undefined: types.EventsOptions
# github.com/elastic/opentelemetry-collector-components/connector/elasticapmconnector
../../../.gvm/pkgsets/go1.24.2/global/pkg/mod/github.com/elastic/opentelemetry-collector-components/connector/[email protected]/connector.go:49:44: cannot convert set (variable of struct type connector.Settings) to type processor.Settings

Moving to draft until these updates are made.

@ycombinator ycombinator marked this pull request as draft May 1, 2025 15:18
@ycombinator ycombinator changed the title Update OTel components to /v1.31.0/v0.125.0 Update OTel components to v1.31.0/v0.125.0 May 1, 2025
@ycombinator ycombinator added backport-8.19 Automated backport to the 8.19 branch and removed backport-active-all Automated backport with mergify to all the active branches labels May 1, 2025
@ycombinator
Copy link
Contributor Author

CI (check-ci step) was failing like so:

  | # github.com/prometheus/prometheus/util/logging
  | ../../../../.asdf/installs/golang/1.24.2/packages/pkg/mod/github.com/prometheus/[email protected]/util/logging/file.go:42:23: undefined: promslog.AllowedFormat
  | Error: failed running go vet, please fix the issues reported: running "go vet ./..." failed with exit code 1

Long story short, the fix for the above has not yet been released in the github.com/prometheus/prometheus Golang module; it looks like the release is being prepared, though: prometheus/prometheus#16434. So this PR here will be blocked on that release.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

mergify bot commented May 7, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update-otel-125 upstream/update-otel-125
git merge upstream/main
git push upstream update-otel-125

@mauri870
Copy link
Member

@ycombinator Looks like prometheus tagged a couple new releases already, I can see 3.3.1 and 3.4.0. Does that mean we can unblock this? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants