Skip to content

[otel] Add e2e test for httpjson input and integration test refactoring #8100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

khushijain21
Copy link
Contributor

What does this PR do?

This PR is part of supporting non-metric input types in otel mode. It adds e2e test for httpjson input. It also refactors/deletes integration tests with duplicated functionality.

Why is it important?

To support non-metric input types

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

source ./env.sh; AGENT_VERSION=9.1.0 go test -tags integration -run TestOtelFilestreamInput ./testing/integration -count=1 -v

Related issues

@khushijain21 khushijain21 requested a review from a team as a code owner May 7, 2025 07:18
@khushijain21 khushijain21 marked this pull request as draft May 7, 2025 07:18
Copy link
Contributor

mergify bot commented May 7, 2025

This pull request does not have a backport label. Could you fix it @khushijain21? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@@ -1409,239 +1191,6 @@ service:
require.True(t, err == nil || errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded), "Retrieved unexpected error: %s", err.Error())
}

func TestHybridAgentE2E(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hybrid functionality and document equivalency is covered by TestOtelFilestreamInput test

@khushijain21 khushijain21 added skip-changelog backport-8.19 Automated backport to the 8.19 branch backport-9.0 Automated backport to the 9.0 branch labels May 7, 2025
@khushijain21 khushijain21 marked this pull request as ready for review May 23, 2025 12:36
Copy link

@pierrehilbert pierrehilbert requested review from pkoutsovasilis and swiatekm and removed request for blakerouse and kaanyalti May 23, 2025 14:07
@elasticmachine
Copy link
Contributor

elasticmachine commented May 23, 2025

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label May 23, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch backport-9.0 Automated backport to the 9.0 branch skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants