-
Notifications
You must be signed in to change notification settings - Fork 204
prepare for windows arm64 builds #9214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request does not have a backport label. Could you fix it @intxgo? 🙏
|
|
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
| #description: | ||
|
|
||
| # Affected component; usually one of "elastic-agent", "fleet-server", "filebeat", "metricbeat", "auditbeat", "all", etc. | ||
| component: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the affected component here? I'm not sure whether it needs to be endpoint or agent. Given that the spec file is changing I would write "elastic-agent"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would omit the changelog for this, the changelog phrasing reads like it is announcing support for Windows ARM64 and this PR on its own is not enough for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the changelog fragment 1f95a74
This reverts commit f4cacca.
|
|
closing as it already went upstream in other PR |





What does this PR do?
Modify Elastic Endpoint spec file to accommodate for future windows arm64 release.
Why is it important?
When windows arm64 package is out the runtime prevention should only prevent installing wrong package for given platform architecture.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself