Skip to content

Conversation

@intxgo
Copy link
Contributor

@intxgo intxgo commented Jul 31, 2025

What does this PR do?

Modify Elastic Endpoint spec file to accommodate for future windows arm64 release.

Why is it important?

When windows arm64 package is out the runtime prevention should only prevent installing wrong package for given platform architecture.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@intxgo intxgo requested a review from a team as a code owner July 31, 2025 10:14
@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025

This pull request does not have a backport label. Could you fix it @intxgo? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@mergify mergify bot assigned intxgo Jul 31, 2025
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Aug 5, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

#description:

# Affected component; usually one of "elastic-agent", "fleet-server", "filebeat", "metricbeat", "auditbeat", "all", etc.
component:
Copy link

@kaanyalti kaanyalti Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the affected component here? I'm not sure whether it needs to be endpoint or agent. Given that the spec file is changing I would write "elastic-agent"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would omit the changelog for this, the changelog phrasing reads like it is announcing support for Windows ARM64 and this PR on its own is not enough for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the changelog fragment 1f95a74

@intxgo intxgo marked this pull request as draft September 3, 2025 11:09
@elastic-sonarqube
Copy link

@dwhyrock
Copy link
Contributor

@intxgo I've added your changes into my PR here: #9751

Hoping that my PR can encompass everything for getting initial Windows/arm64 support added

@intxgo
Copy link
Contributor Author

intxgo commented Nov 17, 2025

closing as it already went upstream in other PR

@intxgo intxgo closed this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants