Enable .NET 5 SDK #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Investigating failures |
stevejgordon
force-pushed
the
infra/dotnet-5-sdk
branch
from
6a66457 to
7721ae8
Compare
NOTE: Required update to 0.12.1 of BenchmarkDotNet to support the shortened TFM. However, this requires explicit LangVersion since latest is not current supported.
stevejgordon
force-pushed
the
infra/dotnet-5-sdk
branch
from
4d60351 to
3737b94
Compare
stevejgordon
commented
Nov 17, 2020
| @@ -3,11 +3,12 @@ | |||
| <PropertyGroup> | |||
| <OutputType>Exe</OutputType> | |||
| <IsPackable>false</IsPackable> | |||
| <TargetFramework>netcoreapp3.1</TargetFramework> | |||
| <TargetFramework>net5.0</TargetFramework> | |||
| <LangVersion>9.0</LangVersion> | |||
There was a problem hiding this comment.
There is a bug in 0.12.1 which means that we cannot use latest here from Directory.Build.props so temporarily fixing this to 9.0.
Once Benchmark.NET includes a fix, we can remove this after updating to that version.
There was a problem hiding this comment.
Is there already an open a ticket for this on Benchmark.NET ?
There was a problem hiding this comment.
Yep, it's fixed and will be in 0.12.2 - dotnet/BenchmarkDotNet#1420
stevejgordon
commented
Nov 17, 2020
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="BenchmarkDotNet" Version="0.12.0" /> | ||
| <PackageReference Include="BenchmarkDotNet" Version="0.12.1" /> |
There was a problem hiding this comment.
Required for net5.0 TFM support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support using newer compiler features such as Source Generators.