-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semantic reranking notebook #308
Conversation
Found 1 changed notebook. Review the changes at https://gitnotebooks.com/elastic/elasticsearch-labs/pull/308 |
}, | ||
"outputs": [], | ||
"source": [ | ||
"url = \"https://raw.githubusercontent.com/elastic/elasticsearch-labs/main/notebooks/search/articles-wikipedia.json\"\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to test before this PR is merged, use this URL:
https://raw.githubusercontent.com/elastic/elasticsearch-labs/2b16684bce3abb31f0e6b20c9a52b0f3208baa2c/notebooks/search/articles-wikipedia.json
bin/find-notebooks-to-test.sh
Outdated
@@ -5,6 +5,7 @@ EXEMPT_NOTEBOOKS=( | |||
"notebooks/esql/esql-getting-started.ipynb" | |||
"notebooks/search/07-inference.ipynb" | |||
"notebooks/search/08-learning-to-rank.ipynb" | |||
"notebooks/search/10-semantic-reranking.ipynb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not testable due to dependency on Cohere API key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change only, otherwise LGTM
Looks good. We already have a Cohere notebook that includes reranking instructions. Consider a sentence or two in the introduction to mention we have a full-blown Cohere notebook, and potentially mention how the |
@leemthompo With regards to mentioning the other Cohere notebook, how about this text? This example will show how to combine search and semantic reranking to improve the accuracy of your search results. We'll be using the rerank feature from Cohere. Note: for a complete integration with Cohere please refer to this notebook. This example focuses on Cohere reranking only through an Elastic retriever query. |
Sounds good. Maybe rename the notebook to semantic-reranking-retrievers-cohere.ipynb because we'll be adding at least one more semantic reranking with retrievers notebook using different providers/Eland option. |
Add notebook on semantic reranking (BM25 search + reranking with Cohere through inference endpoint).